[labs/analyzer] Collect up diagnostics rather than throwing on unexpected (legal) conditions #3866

rictic · 2023-05-03T00:09:12Z

No description provided.

…`ts.DiagnosticCategory`.

I thought it might be useful to collect diagnostics for each module individually and also have a single list with all diagnostics in a program, but there's nothing that needs this right now.

This mostly reverts commit 24ba127, but leaves the part that ignores function overloads.

…ith unsupported name types.

…h non-identifiers.

…nilla JS classes.

This reverts commit 1a98ee7.

…er-diagnostics

changeset-bot · 2023-05-03T00:09:15Z

🦋 Changeset detected

Latest commit: de6f820

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@lit-labs/analyzer	Minor
@lit-labs/cli	Minor
@lit-labs/gen-manifest	Patch
@lit-labs/gen-utils	Patch
@lit-labs/gen-wrapper-angular	Patch
@lit-labs/gen-wrapper-react	Patch
@lit-labs/gen-wrapper-vue	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-05-03T00:09:33Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -3% - +9% (-0.50ms - +1.46ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 76.43ms - 80.63ms
lit-html-kitchen-sink: unsure 🔍 -3% - +10% (-0.90ms - +2.92ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -6% - +6% (-0.67ms - +0.62ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +3% (-0.88ms - +1.91ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -3% - +4% (-1.64ms - +1.82ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 807.11ms - 821.46ms
lit-html-kitchen-sink: unsure 🔍 -2% - +14% (-1.77ms - +10.71ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -2% - +1% (-6.87ms - +2.50ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +2% (-2.09ms - +2.33ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-9.86ms - +12.01ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 778.08ms - 790.46ms
reactive-element-list: unsure 🔍 -1% - +1% (-10.28ms - +7.64ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 112.0.5615.165
Sample size: 50
Built by: Benchmarks #4740
Commit: a8024f5

render

Version	Avg time	vs
	76.43ms - 80.63ms	-

update

Version	Avg time	vs
	807.11ms - 821.46ms	-

update-reflect

Version	Avg time	vs
	778.08ms - 790.46ms	-

lit-html-kitchen-sink

Browser: chrome-headless 112.0.5615.165
Sample size: 30
Built by: Benchmarks #4740
Commit: a8024f5

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	29.96ms - 32.80ms	-	unsure 🔍 -3% - +10% -0.90ms - +2.92ms	unsure 🔍 -4% - +9% -1.13ms - +2.67ms
tip-of-tree tip-of-tree	29.09ms - 31.65ms	unsure 🔍 -9% - +3% -2.92ms - +0.90ms	-	unsure 🔍 -7% - +5% -2.04ms - +1.57ms
previous-release previous-release	29.34ms - 31.88ms	unsure 🔍 -8% - +4% -2.67ms - +1.13ms	unsure 🔍 -5% - +7% -1.57ms - +2.04ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	76.83ms - 88.19ms	-	unsure 🔍 -2% - +14% -1.77ms - +10.71ms	unsure 🔍 -2% - +14% -1.31ms - +10.92ms
tip-of-tree tip-of-tree	75.45ms - 80.63ms	unsure 🔍 -13% - +2% -10.71ms - +1.77ms	-	unsure 🔍 -4% - +5% -3.11ms - +3.79ms
previous-release previous-release	75.42ms - 79.98ms	unsure 🔍 -13% - +1% -10.92ms - +1.31ms	unsure 🔍 -5% - +4% -3.79ms - +3.11ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	16.93ms - 18.54ms	-	unsure 🔍 -3% - +9% -0.50ms - +1.46ms	slower ❌ 2% - 12% 0.38ms - 2.04ms
tip-of-tree tip-of-tree	16.70ms - 17.81ms	unsure 🔍 -8% - +3% -1.46ms - +0.50ms	-	slower ❌ 1% - 8% 0.14ms - 1.31ms
previous-release previous-release	16.34ms - 16.71ms	faster ✔ 2% - 11% 0.38ms - 2.04ms	faster ✔ 1% - 7% 0.14ms - 1.31ms	-

lit-html-repeat

Browser: chrome-headless 112.0.5615.165
Sample size: 30
Built by: Benchmarks #4740
Commit: a8024f5

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	10.66ms - 11.54ms	-	unsure 🔍 -6% - +6% -0.67ms - +0.62ms	unsure 🔍 -7% - +4% -0.79ms - +0.47ms
tip-of-tree tip-of-tree	10.65ms - 11.59ms	unsure 🔍 -6% - +6% -0.62ms - +0.67ms	-	unsure 🔍 -7% - +5% -0.79ms - +0.51ms
previous-release previous-release	10.81ms - 11.71ms	unsure 🔍 -4% - +7% -0.47ms - +0.79ms	unsure 🔍 -5% - +7% -0.51ms - +0.79ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	280.15ms - 286.37ms	-	unsure 🔍 -2% - +1% -6.87ms - +2.50ms	unsure 🔍 -2% - +1% -7.05ms - +3.28ms
tip-of-tree tip-of-tree	281.94ms - 288.95ms	unsure 🔍 -1% - +2% -2.50ms - +6.87ms	-	unsure 🔍 -2% - +2% -5.12ms - +5.72ms
previous-release previous-release	281.01ms - 289.27ms	unsure 🔍 -1% - +2% -3.28ms - +7.05ms	unsure 🔍 -2% - +2% -5.72ms - +5.12ms	-

lit-html-template-heavy

Browser: chrome-headless 112.0.5615.165
Sample size: 50
Built by: Benchmarks #4740
Commit: a8024f5

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	54.70ms - 56.73ms	-	unsure 🔍 -2% - +3% -0.88ms - +1.91ms	unsure 🔍 -2% - +3% -1.21ms - +1.61ms
tip-of-tree tip-of-tree	54.24ms - 56.16ms	unsure 🔍 -3% - +2% -1.91ms - +0.88ms	-	unsure 🔍 -3% - +2% -1.68ms - +1.06ms
previous-release previous-release	54.53ms - 56.49ms	unsure 🔍 -3% - +2% -1.61ms - +1.21ms	unsure 🔍 -2% - +3% -1.06ms - +1.68ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	110.57ms - 113.93ms	-	unsure 🔍 -2% - +2% -2.09ms - +2.33ms	unsure 🔍 -1% - +2% -1.42ms - +2.60ms
tip-of-tree tip-of-tree	110.70ms - 113.56ms	unsure 🔍 -2% - +2% -2.33ms - +2.09ms	-	unsure 🔍 -1% - +2% -1.34ms - +2.27ms
previous-release previous-release	110.56ms - 112.76ms	unsure 🔍 -2% - +1% -2.60ms - +1.42ms	unsure 🔍 -2% - +1% -2.27ms - +1.34ms	-

reactive-element-list

Browser: chrome-headless 112.0.5615.165
Sample size: 50
Built by: Benchmarks #4740
Commit: a8024f5

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	50.39ms - 52.91ms	-	unsure 🔍 -3% - +4% -1.64ms - +1.82ms	unsure 🔍 -5% - +1% -2.78ms - +0.57ms
tip-of-tree tip-of-tree	50.37ms - 52.74ms	unsure 🔍 -4% - +3% -1.82ms - +1.64ms	-	unsure 🔍 -5% - +1% -2.81ms - +0.43ms
previous-release previous-release	51.64ms - 53.86ms	unsure 🔍 -1% - +5% -0.57ms - +2.78ms	unsure 🔍 -1% - +5% -0.43ms - +2.81ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	825.49ms - 840.89ms	-	unsure 🔍 -1% - +1% -9.86ms - +12.01ms	unsure 🔍 -1% - +2% -5.99ms - +14.83ms
tip-of-tree tip-of-tree	824.35ms - 839.87ms	unsure 🔍 -1% - +1% -12.01ms - +9.86ms	-	unsure 🔍 -1% - +2% -7.11ms - +13.80ms
previous-release previous-release	821.77ms - 835.77ms	unsure 🔍 -2% - +1% -14.83ms - +5.99ms	unsure 🔍 -2% - +1% -13.80ms - +7.11ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	817.75ms - 830.24ms	-	unsure 🔍 -1% - +1% -10.28ms - +7.64ms	unsure 🔍 -1% - +1% -8.08ms - +11.28ms
tip-of-tree tip-of-tree	818.89ms - 831.73ms	unsure 🔍 -1% - +1% -7.64ms - +10.28ms	-	unsure 🔍 -1% - +2% -6.87ms - +12.71ms
previous-release previous-release	815.00ms - 829.78ms	unsure 🔍 -1% - +1% -11.28ms - +8.08ms	unsure 🔍 -2% - +1% -12.71ms - +6.87ms	-

_{tachometer-reporter-action v2 for Benchmarks}

Also start with one diagnostic category that's informative ("we don't know how to handle this yet"), and put the rest into the wastebasket taxon

justinfagnani

Nice! A few comments, but none a big deal.

packages/labs/analyzer/src/lib/analyzer.ts

packages/labs/analyzer/src/lib/diagnostic-code.ts

packages/labs/analyzer/src/lib/errors.ts

packages/labs/analyzer/src/lib/javascript/classes.ts

packages/labs/analyzer/src/lib/lit-element/properties.ts

packages/labs/analyzer/src/lib/references.ts

packages/labs/analyzer/src/lib/types.ts

packages/labs/analyzer/src/test/lit-element/properties_test.ts

justinfagnani · 2023-05-04T15:41:07Z

@rictic this looks ready to go, but the conflict has to be resolved. It came from #3812 which change some error cases for parsing CSS variables.

bicknellr and others added 30 commits February 15, 2023 17:33

format

45a4864

Collect declarations synchronously.

24ba127

Add addDiagnostic to AnalyzerInterface.

7da603d

createDiagnostic now accepts an options object which can contain a …

c5efd5e

…`ts.DiagnosticCategory`.

Add DiagnosticCollector.

768d260

Collect diagnostics while analyzing modules.

9dbab2d

Log all diagnostics collected while analyzing a package.

c79815a

Update the warning text.

d54c5f5

Only start a new diagnostic context if the module isn't cached.

81b5602

Add a license header to the new file.

512b4c5

Remove DiagnosticCollector and the concept of nested contexts. (...)

98c6ad6

I thought it might be useful to collect diagnostics for each module individually and also have a single list with all diagnostics in a program, but there's nothing that needs this right now.

Collect declarations async again.

f1abec1

This mostly reverts commit 24ba127, but leaves the part that ignores function overloads.

Log any diagnostics collected while running generators.

dab12dd

Revert some no-op changes.

05dad89

Merge remote-tracking branch 'origin/main' into collect-diagnostics

aedabb4

Add an enum for diagnostic codes produced by the analyzer.

fd61707

Add a test that checks that a diagnostic is produced for properties w…

436aa20

…ith unsupported name types.

Add tests for overloaded function exports and methods.

da9dc35

Replace the DiagnosticCode enum with an object.

eadf60b

Merge remote-tracking branch 'origin/main' into collect-diagnostics

f3130e2

Remove code related to supporting overloaded functions.

1809cf8

addDiagnostic now directly takes a DiagnosticOptions.

b68f395

Add a changeset.

b9a901f

Prevent the LitElement analyzer from analyzing properties named wit…

b70b930

…h non-identifiers.

Remove logDiagnostics method from Analyzer.

1a98ee7

Add a test for the UNSUPPORTED_PROPERTY_NAME_TYPE diagnostic for va…

bd9e8cc

…nilla JS classes.

Revert "Remove logDiagnostics method from Analyzer."

191eaa4

This reverts commit 1a98ee7.

Import AbsolutePath from the main file of @lit-labs/analyzer.

272da5a

Merge remote-tracking branch 'origin/main' into collect-diagnostics

a0f3911

Make analyzer keep going and accumulate diagnostics.

e6cd778

Merge remote-tracking branch 'origin/collect-diagnostics' into analyz…

2303da4

…er-diagnostics

rictic added 2 commits May 2, 2023 17:11

Clarify changest

db96be9

Standardize on a single way to create diagnostics

65f6cf7

Also start with one diagnostic category that's informative ("we don't know how to handle this yet"), and put the rest into the wastebasket taxon

rictic marked this pull request as ready for review May 3, 2023 00:56

rictic requested a review from kevinpschaaf as a code owner May 3, 2023 00:56

rictic requested a review from justinfagnani May 3, 2023 00:56

Small ESM compat fix.

4267d7d

justinfagnani reviewed May 3, 2023

View reviewed changes

rictic added 2 commits May 3, 2023 14:04

Address review comments

2b5cf42

Trivial fix

24c9fa8

justinfagnani approved these changes May 3, 2023

View reviewed changes

rictic added 2 commits May 4, 2023 13:26

Mention why we start with a high number.

57eface

Merge branch 'main' into analyzer-diagnostics

de6f820

rictic enabled auto-merge (squash) May 4, 2023 20:33

rictic merged commit d8e8065 into main May 4, 2023

rictic deleted the analyzer-diagnostics branch May 4, 2023 20:53

lit-robot mentioned this pull request May 11, 2023

Version Packages #3898

Merged

rictic mentioned this pull request May 31, 2023

[labs/analyzer] Collect and log non-fatal diagnostics. #3678

Closed

43081j mentioned this pull request Jul 11, 2023

fix: derive files from tsconfigs which extend #4006

Merged

[labs/analyzer] Collect up diagnostics rather than throwing on unexpected (legal) conditions #3866

[labs/analyzer] Collect up diagnostics rather than throwing on unexpected (legal) conditions #3866

Uh oh!

Conversation

rictic commented May 3, 2023

Uh oh!

changeset-bot bot commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

justinfagnani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

justinfagnani commented May 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented May 3, 2023 •

edited

Loading

github-actions bot commented May 3, 2023 •

edited

Loading