[labs/ssr-react] Handle children passed in via props #3861

augustjk · 2023-04-29T00:08:16Z

The runtime jsx mode were never affected by this as they always get children passed in via the props object.

changeset-bot · 2023-04-29T00:08:19Z

🦋 Changeset detected

Latest commit: a022dae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lit-labs/ssr-react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-04-29T00:08:37Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -5% - +1% (-1.09ms - +0.30ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 101.95ms - 109.20ms
lit-html-kitchen-sink: unsure 🔍 -5% - +3% (-2.23ms - +1.31ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -8% - +7% (-1.13ms - +0.91ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +4% (-0.53ms - +3.05ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -5% - +2% (-3.72ms - +1.32ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 1044.90ms - 1069.22ms
lit-html-kitchen-sink: unsure 🔍 -6% - +2% (-6.33ms - +1.94ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -5% - +2% (-15.40ms - +5.70ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -0% - +6% (-0.25ms - +8.15ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -2% - +1% (-27.08ms - +8.71ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 1013.84ms - 1039.61ms
reactive-element-list: unsure 🔍 -3% - +0% (-34.32ms - +3.01ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 112.0.5615.165
Sample size: 50
Built by: Benchmarks #4733
Commit: fe52656

render

Version	Avg time	vs
	101.95ms - 109.20ms	-

update

Version	Avg time	vs
	1044.90ms - 1069.22ms	-

update-reflect

Version	Avg time	vs
	1013.84ms - 1039.61ms	-

lit-html-kitchen-sink

Browser: chrome-headless 112.0.5615.165
Sample size: 30
Built by: Benchmarks #4733
Commit: fe52656

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	41.14ms - 43.76ms	-	unsure 🔍 -5% - +3% -2.23ms - +1.31ms	unsure 🔍 -4% - +5% -1.61ms - +2.30ms
tip-of-tree tip-of-tree	41.72ms - 44.10ms	unsure 🔍 -3% - +5% -1.31ms - +2.23ms	-	unsure 🔍 -3% - +6% -1.07ms - +2.68ms
previous-release previous-release	40.65ms - 43.56ms	unsure 🔍 -5% - +4% -2.30ms - +1.61ms	unsure 🔍 -6% - +2% -2.68ms - +1.07ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	99.34ms - 103.96ms	-	unsure 🔍 -6% - +2% -6.33ms - +1.94ms	unsure 🔍 -5% - +2% -5.58ms - +1.88ms
tip-of-tree tip-of-tree	100.41ms - 107.28ms	unsure 🔍 -2% - +6% -1.94ms - +6.33ms	-	unsure 🔍 -4% - +5% -4.17ms - +4.86ms
previous-release previous-release	100.57ms - 106.43ms	unsure 🔍 -2% - +6% -1.88ms - +5.58ms	unsure 🔍 -5% - +4% -4.86ms - +4.17ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	18.97ms - 19.75ms	-	unsure 🔍 -5% - +1% -1.09ms - +0.30ms	unsure 🔍 -5% - +2% -1.09ms - +0.31ms
tip-of-tree tip-of-tree	19.18ms - 20.33ms	unsure 🔍 -2% - +6% -0.30ms - +1.09ms	-	unsure 🔍 -4% - +4% -0.82ms - +0.83ms
previous-release previous-release	19.16ms - 20.34ms	unsure 🔍 -2% - +6% -0.31ms - +1.09ms	unsure 🔍 -4% - +4% -0.83ms - +0.82ms	-

lit-html-repeat

Browser: chrome-headless 112.0.5615.165
Sample size: 30
Built by: Benchmarks #4733
Commit: fe52656

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	12.75ms - 14.43ms	-	unsure 🔍 -8% - +7% -1.13ms - +0.91ms	unsure 🔍 -9% - +5% -1.20ms - +0.68ms
tip-of-tree tip-of-tree	13.12ms - 14.28ms	unsure 🔍 -7% - +8% -0.91ms - +1.13ms	-	unsure 🔍 -6% - +4% -0.87ms - +0.57ms
previous-release previous-release	13.43ms - 14.27ms	unsure 🔍 -5% - +9% -0.68ms - +1.20ms	unsure 🔍 -4% - +6% -0.57ms - +0.87ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	322.42ms - 338.07ms	-	unsure 🔍 -5% - +2% -15.40ms - +5.70ms	unsure 🔍 -4% - +2% -14.75ms - +6.25ms
tip-of-tree tip-of-tree	328.02ms - 342.17ms	unsure 🔍 -2% - +5% -5.70ms - +15.40ms	-	unsure 🔍 -3% - +3% -9.36ms - +10.56ms
previous-release previous-release	327.49ms - 341.51ms	unsure 🔍 -2% - +4% -6.25ms - +14.75ms	unsure 🔍 -3% - +3% -10.56ms - +9.36ms	-

lit-html-template-heavy

Browser: chrome-headless 112.0.5615.165
Sample size: 50
Built by: Benchmarks #4733
Commit: fe52656

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	71.61ms - 74.36ms	-	unsure 🔍 -1% - +4% -0.53ms - +3.05ms	unsure 🔍 -1% - +5% -0.38ms - +3.29ms
tip-of-tree tip-of-tree	70.58ms - 72.87ms	unsure 🔍 -4% - +1% -3.05ms - +0.53ms	-	unsure 🔍 -2% - +3% -1.48ms - +1.87ms
previous-release previous-release	70.31ms - 72.75ms	unsure 🔍 -4% - +0% -3.29ms - +0.38ms	unsure 🔍 -3% - +2% -1.87ms - +1.48ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	148.42ms - 154.91ms	-	unsure 🔍 -0% - +6% -0.25ms - +8.15ms	unsure 🔍 -0% - +6% -0.28ms - +8.86ms
tip-of-tree tip-of-tree	145.06ms - 150.38ms	unsure 🔍 -5% - +0% -8.15ms - +0.25ms	-	unsure 🔍 -3% - +3% -3.83ms - +4.52ms
previous-release previous-release	144.16ms - 150.59ms	unsure 🔍 -6% - +0% -8.86ms - +0.28ms	unsure 🔍 -3% - +3% -4.52ms - +3.83ms	-

reactive-element-list

Browser: chrome-headless 112.0.5615.165
Sample size: 50
Built by: Benchmarks #4733
Commit: fe52656

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	70.91ms - 74.62ms	-	unsure 🔍 -5% - +2% -3.72ms - +1.32ms	unsure 🔍 -3% - +3% -2.19ms - +2.44ms
tip-of-tree tip-of-tree	72.26ms - 75.67ms	unsure 🔍 -2% - +5% -1.32ms - +3.72ms	-	unsure 🔍 -1% - +5% -0.87ms - +3.52ms
previous-release previous-release	71.26ms - 74.02ms	unsure 🔍 -3% - +3% -2.44ms - +2.19ms	unsure 🔍 -5% - +1% -3.52ms - +0.87ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1070.13ms - 1093.80ms	-	unsure 🔍 -2% - +1% -27.08ms - +8.71ms	unsure 🔍 -2% - +1% -18.93ms - +13.69ms
tip-of-tree tip-of-tree	1077.72ms - 1104.58ms	unsure 🔍 -1% - +3% -8.71ms - +27.08ms	-	unsure 🔍 -1% - +2% -10.93ms - +24.07ms
previous-release previous-release	1073.36ms - 1095.81ms	unsure 🔍 -1% - +2% -13.69ms - +18.93ms	unsure 🔍 -2% - +1% -24.07ms - +10.93ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1078.01ms - 1103.35ms	-	unsure 🔍 -3% - +0% -34.32ms - +3.01ms	unsure 🔍 -1% - +2% -15.92ms - +17.31ms
tip-of-tree tip-of-tree	1092.62ms - 1120.05ms	unsure 🔍 -0% - +3% -3.01ms - +34.32ms	-	unsure 🔍 -0% - +3% -1.07ms - +33.77ms
previous-release previous-release	1079.24ms - 1100.73ms	unsure 🔍 -2% - +1% -17.31ms - +15.92ms	unsure 🔍 -3% - +0% -33.77ms - +1.07ms	-

_{tachometer-reporter-action v2 for Benchmarks}

packages/labs/ssr-react/src/lib/node/wrap-create-element.ts

…ildren

raoufswe · 2023-05-09T21:48:05Z

thank youu @augustjk for working on this!

I see you already have released a new version of ssr-react to 1.1.2, but the next wrapper is still pointing to an older version of it. do you reckon we need to update the next wrapper as well or i am doing something wrong?

I explicitly sat my ssr-react version to 1.1.2 via

  "resolutions": {
    "@lit-labs/ssr-react": "0.1.2"
  }

and the error seems to be resolved 🥳

augustjk · 2023-05-09T22:18:11Z

@raoufswe because of the semver range a fresh install would normally install the latest version of @lit-labs/ssr-react even though @lit-labs/nextjs doesn't specify it. existing projects would have to do a manual update for it. for npm, doing npm update @lit-labs/ssr-react works even if it is not listed directly in package.json. i don't use yarn but i'm hoping yarn upgrade works similarly? there's also the approach of deleting the lockfile and re-installing to grab the latest semver acceptable version of all your dependencies.

@lit-labs/ssr-react being a nested dependency, there might be a risk of outdated version checks not picking up the new version. our default release approach is to only bump version when a dependency gets a minor version bump. if we do one for every patch, it could cause a lot of new versions. perhaps that's not such a bad thing but it's how we have it for now.

raoufswe · 2023-05-09T22:27:59Z

I deleted my lockfile and re-run yarn and it picked up the latest version indeed. thank youu <3

augustjk added 3 commits April 28, 2023 16:57

Check for children passed in via props

44567f3

Add tests for children in props

c2b6869

Add changeset

1c452ed

augustjk requested a review from justinfagnani as a code owner April 29, 2023 00:08

augustjk requested a review from AndrewJakubowicz April 29, 2023 00:08

justinfagnani reviewed May 3, 2023

View reviewed changes

packages/labs/ssr-react/src/lib/node/wrap-create-element.ts Outdated Show resolved Hide resolved

packages/labs/ssr-react/src/lib/node/wrap-create-element.ts Outdated Show resolved Hide resolved

augustjk added 2 commits May 2, 2023 19:00

Use PropsWithChildren type from React

6119fc6

Emulate React.createElement by preferring children args over props.ch…

a022dae

…ildren

augustjk requested a review from kevinpschaaf as a code owner May 3, 2023 02:07

augustjk requested a review from justinfagnani May 3, 2023 02:10

justinfagnani approved these changes May 3, 2023

View reviewed changes

augustjk merged commit 8deca6e into main May 3, 2023

augustjk deleted the ssr-react-children branch May 3, 2023 17:18

lit-robot mentioned this pull request May 4, 2023

[labs/virtualizer] Version Packages #3878

Merged

[labs/ssr-react] Handle children passed in via props #3861

[labs/ssr-react] Handle children passed in via props #3861

Uh oh!

Conversation

augustjk commented Apr 29, 2023

Uh oh!

changeset-bot bot commented Apr 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Apr 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

Uh oh!

Uh oh!

raoufswe commented May 9, 2023

Uh oh!

augustjk commented May 9, 2023

Uh oh!

raoufswe commented May 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Apr 29, 2023 •

edited

Loading

github-actions bot commented Apr 29, 2023 •

edited

Loading