Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/virtualizer] Fix #3873 (visibilityChanged regression) #3874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graynorton merged 2 commits into from
May 4, 2023
Merged

[labs/virtualizer] Fix #3873 (visibilityChanged regression) #3874

graynorton merged 2 commits into from
May 4, 2023

Conversation

@graynorton
Copy link
Contributor

@graynorton graynorton commented May 4, 2023

No description provided.

@graynorton graynorton requested a review from kevinpschaaf as a code owner May 4, 2023 01:25
@changeset-bot
Copy link

changeset-bot bot commented May 4, 2023

🦋 Changeset detected

Latest commit: f3e1bbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/virtualizer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -4% - +1% (-0.88ms - +0.20ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 106.07ms - 110.71ms
  • lit-html-kitchen-sink: unsure 🔍 -4% - +4% (-1.97ms - +1.90ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -9% - +2% (-1.35ms - +0.34ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -5% - +1% (-3.68ms - +0.67ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -4% - +3% (-3.35ms - +2.39ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 1107.71ms - 1122.96ms
  • lit-html-kitchen-sink: faster ✔ 2% - 10% (1.73ms - 12.19ms)
    this-change vs tip-of-tree
  • lit-html-repeat: faster ✔ 1% - 6% (2.41ms - 20.71ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +3% (-4.95ms - +4.48ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +0% (-24.91ms - +3.99ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 1090.14ms - 1111.01ms
  • reactive-element-list: unsure 🔍 -2% - +1% (-27.12ms - +6.11ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
106.07ms - 110.71ms-

update

VersionAvg timevs
1107.71ms - 1122.96ms-

update-reflect

VersionAvg timevs
1090.14ms - 1111.01ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
44.18ms - 46.64ms-unsure 🔍
-4% - +4%
-1.97ms - +1.90ms		unsure 🔍
-2% - +6%
-0.73ms - +2.80ms
tip-of-tree
tip-of-tree		43.96ms - 46.94msunsure 🔍
-4% - +4%
-1.90ms - +1.97ms		-unsure 🔍
-2% - +7%
-0.88ms - +3.02ms
previous-release
previous-release		43.11ms - 45.64msunsure 🔍
-6% - +2%
-2.80ms - +0.73ms		unsure 🔍
-7% - +2%
-3.02ms - +0.88ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
106.95ms - 113.66ms-faster ✔
2% - 10%
1.73ms - 12.19ms		unsure 🔍
-8% - +2%
-8.93ms - +2.17ms
tip-of-tree
tip-of-tree		113.25ms - 121.27msslower ❌
1% - 11%
1.73ms - 12.19ms		-unsure 🔍
-2% - +8%
-2.38ms - +9.55ms
previous-release
previous-release		109.26ms - 118.10msunsure 🔍
-2% - +8%
-2.17ms - +8.93ms		unsure 🔍
-8% - +2%
-9.55ms - +2.38ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
20.09ms - 20.88ms-unsure 🔍
-4% - +1%
-0.88ms - +0.20ms		unsure 🔍
-5% - +2%
-0.98ms - +0.49ms
tip-of-tree
tip-of-tree		20.46ms - 21.20msunsure 🔍
-1% - +4%
-0.20ms - +0.88ms		-unsure 🔍
-3% - +4%
-0.63ms - +0.82ms
previous-release
previous-release		20.11ms - 21.36msunsure 🔍
-2% - +5%
-0.49ms - +0.98ms		unsure 🔍
-4% - +3%
-0.82ms - +0.63ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
13.24ms - 14.24ms-unsure 🔍
-9% - +2%
-1.35ms - +0.34ms		unsure 🔍
-8% - +4%
-1.13ms - +0.62ms
tip-of-tree
tip-of-tree		13.56ms - 14.93msunsure 🔍
-3% - +10%
-0.34ms - +1.35ms		-unsure 🔍
-5% - +9%
-0.74ms - +1.24ms
previous-release
previous-release		13.27ms - 14.71msunsure 🔍
-5% - +8%
-0.62ms - +1.13ms		unsure 🔍
-9% - +5%
-1.24ms - +0.74ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
329.85ms - 341.82ms-faster ✔
1% - 6%
2.41ms - 20.71ms		unsure 🔍
-3% - +2%
-10.98ms - +7.20ms
tip-of-tree
tip-of-tree		340.47ms - 354.31msslower ❌
1% - 6%
2.41ms - 20.71ms		-unsure 🔍
-0% - +6%
-0.07ms - +19.40ms
previous-release
previous-release		330.88ms - 344.57msunsure 🔍
-2% - +3%
-7.20ms - +10.98ms		unsure 🔍
-6% - -0%
-19.40ms - +0.07ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
70.68ms - 73.83ms-unsure 🔍
-5% - +1%
-3.68ms - +0.67ms		unsure 🔍
-6% - +0%
-4.58ms - +0.10ms
tip-of-tree
tip-of-tree		72.26ms - 75.26msunsure 🔍
-1% - +5%
-0.67ms - +3.68ms		-unsure 🔍
-4% - +2%
-3.02ms - +1.55ms
previous-release
previous-release		72.77ms - 76.22msunsure 🔍
-0% - +6%
-0.10ms - +4.58ms		unsure 🔍
-2% - +4%
-1.55ms - +3.02ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
149.22ms - 155.50ms-unsure 🔍
-3% - +3%
-4.95ms - +4.48ms		unsure 🔍
-5% - +1%
-7.60ms - +1.15ms
tip-of-tree
tip-of-tree		149.07ms - 156.12msunsure 🔍
-3% - +3%
-4.48ms - +4.95ms		-unsure 🔍
-5% - +1%
-7.65ms - +1.67ms
previous-release
previous-release		152.54ms - 158.63msunsure 🔍
-1% - +5%
-1.15ms - +7.60ms		unsure 🔍
-1% - +5%
-1.67ms - +7.65ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
75.68ms - 79.52ms-unsure 🔍
-4% - +3%
-3.35ms - +2.39ms		unsure 🔍
-6% - +1%
-4.73ms - +1.00ms
tip-of-tree
tip-of-tree		75.95ms - 80.22msunsure 🔍
-3% - +4%
-2.39ms - +3.35ms		-unsure 🔍
-6% - +2%
-4.40ms - +1.63ms
previous-release
previous-release		77.34ms - 81.60msunsure 🔍
-1% - +6%
-1.00ms - +4.73ms		unsure 🔍
-2% - +6%
-1.63ms - +4.40ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1127.71ms - 1148.88ms-unsure 🔍
-2% - +0%
-24.91ms - +3.99ms		unsure 🔍
-2% - +1%
-24.21ms - +8.70ms
tip-of-tree
tip-of-tree		1138.91ms - 1158.58msunsure 🔍
-0% - +2%
-3.99ms - +24.91ms		-unsure 🔍
-1% - +2%
-13.28ms - +18.68ms
previous-release
previous-release		1133.45ms - 1158.64msunsure 🔍
-1% - +2%
-8.70ms - +24.21ms		unsure 🔍
-2% - +1%
-18.68ms - +13.28ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1135.77ms - 1158.67ms-unsure 🔍
-2% - +1%
-27.12ms - +6.11ms		unsure 🔍
-3% - +0%
-30.49ms - +3.19ms
tip-of-tree
tip-of-tree		1145.69ms - 1169.76msunsure 🔍
-1% - +2%
-6.11ms - +27.12ms		-unsure 🔍
-2% - +1%
-20.39ms - +14.11ms
previous-release
previous-release		1148.52ms - 1173.23msunsure 🔍
-0% - +3%
-3.19ms - +30.49ms		unsure 🔍
-1% - +2%
-14.11ms - +20.39ms		-

tachometer-reporter-action v2 for Benchmarks

@graynorton graynorton requested a review from usergenic May 4, 2023 01:26
@usergenic
Copy link
Contributor

usergenic commented May 4, 2023

Interesting. I guess the visibility change tests we have right now only test the case where item sizes are adjusted to make things become visible/invisible. Will keep in mind when reworking tests, to make sure the tests cover more of the expected triggers...

LGTM

@graynorton graynorton merged commit d32eec7 into main May 4, 2023
@graynorton graynorton deleted the virtualizer-fix-visibility-changed branch May 4, 2023 20:54
@usergenic usergenic changed the title Virtualizer: Fix #3873 (visibilityChanged regression) [labs/virtualizer] Fix #3873 (visibilityChanged regression) May 10, 2023
@lit-robot lit-robot mentioned this pull request May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

1 more reviewer

@usergenic usergenic usergenic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@graynorton @usergenic