Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/virtualizer] Switch innerHTML to textContent and add some explicit types #3877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
usergenic merged 2 commits into from
May 4, 2023
Merged

[labs/virtualizer] Switch innerHTML to textContent and add some explicit types #3877

usergenic merged 2 commits into from
May 4, 2023

Conversation

@usergenic
Copy link
Contributor

@usergenic usergenic commented May 4, 2023

Internal typescript restrictions highlighted called out a use of innerHTML assignment a couple of types that were not explicit enough in Virtualizer.ts

@usergenic usergenic requested a review from kevinpschaaf as a code owner May 4, 2023 17:59
@changeset-bot
Copy link

changeset-bot bot commented May 4, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d93f364

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/virtualizer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -4% - +5% (-0.68ms - +0.87ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 75.92ms - 80.51ms
  • lit-html-kitchen-sink: unsure 🔍 -6% - +7% (-1.89ms - +2.13ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -5% - +7% (-0.53ms - +0.76ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -5% - +2% (-2.73ms - +0.91ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -4% - +2% (-1.93ms - +1.15ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 785.74ms - 796.53ms
  • lit-html-kitchen-sink: unsure 🔍 -3% - +7% (-2.66ms - +6.18ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +3% (-7.31ms - +9.45ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +1% (-2.07ms - +1.83ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-9.61ms - +8.29ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 757.51ms - 765.62ms
  • reactive-element-list: unsure 🔍 -0% - +2% (-3.46ms - +12.16ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
75.92ms - 80.51ms-

update

VersionAvg timevs
785.74ms - 796.53ms-

update-reflect

VersionAvg timevs
757.51ms - 765.62ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
30.12ms - 33.06ms-unsure 🔍
-6% - +7%
-1.89ms - +2.13ms		unsure 🔍
-5% - +8%
-1.49ms - +2.33ms
tip-of-tree
tip-of-tree		30.11ms - 32.84msunsure 🔍
-7% - +6%
-2.13ms - +1.89ms		-unsure 🔍
-5% - +7%
-1.53ms - +2.13ms
previous-release
previous-release		29.95ms - 32.39msunsure 🔍
-7% - +5%
-2.33ms - +1.49ms		unsure 🔍
-7% - +5%
-2.13ms - +1.53ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
82.50ms - 89.33ms-unsure 🔍
-3% - +7%
-2.66ms - +6.18ms		unsure 🔍
-3% - +7%
-2.60ms - +5.88ms
tip-of-tree
tip-of-tree		81.36ms - 86.95msunsure 🔍
-7% - +3%
-6.18ms - +2.66ms		-unsure 🔍
-5% - +4%
-3.88ms - +3.64ms
previous-release
previous-release		81.76ms - 86.79msunsure 🔍
-7% - +3%
-5.88ms - +2.60ms		unsure 🔍
-4% - +5%
-3.64ms - +3.88ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
16.92ms - 18.21ms-unsure 🔍
-4% - +5%
-0.68ms - +0.87ms		unsure 🔍
-5% - +5%
-0.95ms - +0.95ms
tip-of-tree
tip-of-tree		17.04ms - 17.90msunsure 🔍
-5% - +4%
-0.87ms - +0.68ms		-unsure 🔍
-5% - +4%
-0.91ms - +0.73ms
previous-release
previous-release		16.86ms - 18.26msunsure 🔍
-5% - +5%
-0.95ms - +0.95ms		unsure 🔍
-4% - +5%
-0.73ms - +0.91ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
10.52ms - 11.41ms-unsure 🔍
-5% - +7%
-0.53ms - +0.76ms		unsure 🔍
-6% - +6%
-0.66ms - +0.64ms
tip-of-tree
tip-of-tree		10.39ms - 11.31msunsure 🔍
-7% - +5%
-0.76ms - +0.53ms		-unsure 🔍
-7% - +5%
-0.78ms - +0.54ms
previous-release
previous-release		10.50ms - 11.44msunsure 🔍
-6% - +6%
-0.64ms - +0.66ms		unsure 🔍
-5% - +7%
-0.54ms - +0.78ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
288.21ms - 298.26ms-unsure 🔍
-3% - +3%
-7.31ms - +9.45ms		unsure 🔍
-1% - +3%
-2.91ms - +9.18ms
tip-of-tree
tip-of-tree		285.46ms - 298.87msunsure 🔍
-3% - +2%
-9.45ms - +7.31ms		-unsure 🔍
-2% - +3%
-5.44ms - +9.56ms
previous-release
previous-release		286.74ms - 293.46msunsure 🔍
-3% - +1%
-9.18ms - +2.91ms		unsure 🔍
-3% - +2%
-9.56ms - +5.44ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
55.98ms - 58.12ms-unsure 🔍
-5% - +2%
-2.73ms - +0.91ms		unsure 🔍
-1% - +4%
-0.60ms - +2.21ms
tip-of-tree
tip-of-tree		56.49ms - 59.43msunsure 🔍
-2% - +5%
-0.91ms - +2.73ms		-unsure 🔍
-0% - +6%
-0.01ms - +3.45ms
previous-release
previous-release		55.33ms - 57.16msunsure 🔍
-4% - +1%
-2.21ms - +0.60ms		unsure 🔍
-6% - -0%
-3.45ms - +0.01ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
120.57ms - 122.94ms-unsure 🔍
-2% - +1%
-2.07ms - +1.83ms		unsure 🔍
-1% - +2%
-0.79ms - +2.61ms
tip-of-tree
tip-of-tree		120.33ms - 123.43msunsure 🔍
-2% - +2%
-1.83ms - +2.07ms		-unsure 🔍
-1% - +2%
-0.94ms - +3.01ms
previous-release
previous-release		119.63ms - 122.07msunsure 🔍
-2% - +1%
-2.61ms - +0.79ms		unsure 🔍
-2% - +1%
-3.01ms - +0.94ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
50.88ms - 53.11ms-unsure 🔍
-4% - +2%
-1.93ms - +1.15ms		unsure 🔍
-2% - +4%
-1.15ms - +2.18ms
tip-of-tree
tip-of-tree		51.32ms - 53.44msunsure 🔍
-2% - +4%
-1.15ms - +1.93ms		-unsure 🔍
-1% - +5%
-0.72ms - +2.53ms
previous-release
previous-release		50.24ms - 52.71msunsure 🔍
-4% - +2%
-2.18ms - +1.15ms		unsure 🔍
-5% - +1%
-2.53ms - +0.72ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
796.37ms - 809.96ms-unsure 🔍
-1% - +1%
-9.61ms - +8.29ms		unsure 🔍
-2% - +0%
-14.02ms - +3.84ms
tip-of-tree
tip-of-tree		798.00ms - 809.65msunsure 🔍
-1% - +1%
-8.29ms - +9.61ms		-unsure 🔍
-2% - +0%
-12.66ms - +3.78ms
previous-release
previous-release		802.46ms - 814.06msunsure 🔍
-0% - +2%
-3.84ms - +14.02ms		unsure 🔍
-0% - +2%
-3.78ms - +12.66ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
795.25ms - 807.51ms-unsure 🔍
-0% - +2%
-3.46ms - +12.16ms		unsure 🔍
-0% - +2%
-3.51ms - +13.10ms
tip-of-tree
tip-of-tree		792.19ms - 801.87msunsure 🔍
-2% - +0%
-12.16ms - +3.46ms		-unsure 🔍
-1% - +1%
-6.96ms - +7.85ms
previous-release
previous-release		790.98ms - 802.19msunsure 🔍
-2% - +0%
-13.10ms - +3.51ms		unsure 🔍
-1% - +1%
-7.85ms - +6.96ms		-

tachometer-reporter-action v2 for Benchmarks

@usergenic usergenic requested a review from graynorton May 4, 2023 17:59
graynorton
graynorton approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@graynorton graynorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usergenic usergenic merged commit 4418bed into main May 4, 2023
@usergenic usergenic deleted the no_innerHTML branch May 4, 2023 23:09
rictic pushed a commit that referenced this pull request May 9, 2023
@usergenic @rictic
Switch innerHTML to textContent and add some explicit types (#3877)
10d614c 
* Switch innerHTML= to textContent= and add some explicit types.

* Added changeset for the innerHTML->textContent change.
@usergenic usergenic changed the title Switch innerHTML to textContent and add some explicit types [labs/virtualizer] Switch innerHTML to textContent and add some explicit types May 10, 2023
@lit-robot lit-robot mentioned this pull request May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graynorton graynorton graynorton approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@usergenic @graynorton