Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/virtualizer] Add missing license headers to files to placate the compliance checks. #3884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
usergenic merged 3 commits into from
May 8, 2023
Merged

[labs/virtualizer] Add missing license headers to files to placate the compliance checks. #3884

usergenic merged 3 commits into from
May 8, 2023

Conversation

@usergenic
Copy link
Contributor

@usergenic usergenic commented May 5, 2023

g3 sync prereq

@usergenic usergenic requested a review from kevinpschaaf as a code owner May 5, 2023 21:06
@changeset-bot
Copy link

changeset-bot bot commented May 5, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: da47f0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/virtualizer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -9% - +4% (-1.62ms - +0.70ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 74.62ms - 78.98ms
  • lit-html-kitchen-sink: unsure 🔍 -4% - +7% (-1.17ms - +2.09ms)
    this-change vs tip-of-tree
  • lit-html-repeat: faster ✔ 1% - 12% (0.12ms - 1.41ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -4% - +1% (-2.12ms - +0.30ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -4% - +1% (-2.18ms - +0.57ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 746.66ms - 756.06ms
  • lit-html-kitchen-sink: unsure 🔍 -1% - +6% (-1.08ms - +4.20ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +2% (-7.83ms - +6.81ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +2% (-1.67ms - +1.93ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +0% (-10.25ms - +3.07ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 720.53ms - 729.93ms
  • reactive-element-list: faster ✔ 0% - 2% (2.52ms - 14.45ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
74.62ms - 78.98ms-

update

VersionAvg timevs
746.66ms - 756.06ms-

update-reflect

VersionAvg timevs
720.53ms - 729.93ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
29.83ms - 32.29ms-unsure 🔍
-4% - +7%
-1.17ms - +2.09ms		unsure 🔍
-8% - +7%
-2.63ms - +2.08ms
tip-of-tree
tip-of-tree		29.53ms - 31.67msunsure 🔍
-7% - +4%
-2.09ms - +1.17ms		-unsure 🔍
-9% - +5%
-3.01ms - +1.53ms
previous-release
previous-release		29.33ms - 33.34msunsure 🔍
-7% - +8%
-2.08ms - +2.63ms		unsure 🔍
-5% - +10%
-1.53ms - +3.01ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
74.01ms - 78.08ms-unsure 🔍
-1% - +6%
-1.08ms - +4.20ms		unsure 🔍
-6% - +2%
-4.92ms - +1.25ms
tip-of-tree
tip-of-tree		72.80ms - 76.16msunsure 🔍
-5% - +1%
-4.20ms - +1.08ms		-faster ✔
1% - 8%
0.54ms - 6.26ms
previous-release
previous-release		75.56ms - 80.20msunsure 🔍
-2% - +7%
-1.25ms - +4.92ms		slower ❌
1% - 8%
0.54ms - 6.26ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
16.15ms - 17.69ms-unsure 🔍
-9% - +4%
-1.62ms - +0.70ms		unsure 🔍
-7% - +5%
-1.15ms - +0.93ms
tip-of-tree
tip-of-tree		16.52ms - 18.25msunsure 🔍
-4% - +10%
-0.70ms - +1.62ms		-unsure 🔍
-4% - +9%
-0.76ms - +1.46ms
previous-release
previous-release		16.34ms - 17.73msunsure 🔍
-6% - +7%
-0.93ms - +1.15ms		unsure 🔍
-8% - +4%
-1.46ms - +0.76ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
9.89ms - 10.79ms-faster ✔
1% - 12%
0.12ms - 1.41ms		faster ✔
1% - 12%
0.10ms - 1.36ms
tip-of-tree
tip-of-tree		10.64ms - 11.56msslower ❌
1% - 14%
0.12ms - 1.41ms		-unsure 🔍
-5% - +6%
-0.60ms - +0.67ms
previous-release
previous-release		10.63ms - 11.51msslower ❌
1% - 13%
0.10ms - 1.36ms		unsure 🔍
-6% - +5%
-0.67ms - +0.60ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
278.88ms - 289.43ms-unsure 🔍
-3% - +2%
-7.83ms - +6.81ms		unsure 🔍
-1% - +3%
-4.13ms - +9.76ms
tip-of-tree
tip-of-tree		279.58ms - 289.74msunsure 🔍
-2% - +3%
-6.81ms - +7.83ms		-unsure 🔍
-1% - +4%
-3.47ms - +10.13ms
previous-release
previous-release		276.82ms - 285.86msunsure 🔍
-3% - +1%
-9.76ms - +4.13ms		unsure 🔍
-4% - +1%
-10.13ms - +3.47ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
53.64ms - 55.20ms-unsure 🔍
-4% - +1%
-2.12ms - +0.30ms		unsure 🔍
-3% - +1%
-1.67ms - +0.70ms
tip-of-tree
tip-of-tree		54.41ms - 56.25msunsure 🔍
-1% - +4%
-0.30ms - +2.12ms		-unsure 🔍
-2% - +3%
-0.85ms - +1.71ms
previous-release
previous-release		54.02ms - 55.79msunsure 🔍
-1% - +3%
-0.70ms - +1.67ms		unsure 🔍
-3% - +2%
-1.71ms - +0.85ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
112.36ms - 114.89ms-unsure 🔍
-1% - +2%
-1.67ms - +1.93ms		unsure 🔍
-1% - +3%
-1.64ms - +2.85ms
tip-of-tree
tip-of-tree		112.22ms - 114.77msunsure 🔍
-2% - +1%
-1.93ms - +1.67ms		-unsure 🔍
-2% - +2%
-1.77ms - +2.73ms
previous-release
previous-release		111.16ms - 114.87msunsure 🔍
-3% - +1%
-2.85ms - +1.64ms		unsure 🔍
-2% - +2%
-2.73ms - +1.77ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
49.40ms - 51.47ms-unsure 🔍
-4% - +1%
-2.18ms - +0.57ms		unsure 🔍
-3% - +3%
-1.55ms - +1.50ms
tip-of-tree
tip-of-tree		50.34ms - 52.14msunsure 🔍
-1% - +4%
-0.57ms - +2.18ms		-unsure 🔍
-1% - +4%
-0.67ms - +2.22ms
previous-release
previous-release		49.34ms - 51.59msunsure 🔍
-3% - +3%
-1.50ms - +1.55ms		unsure 🔍
-4% - +1%
-2.22ms - +0.67ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
758.12ms - 767.39ms-unsure 🔍
-1% - +0%
-10.25ms - +3.07ms		unsure 🔍
-2% - +0%
-14.27ms - +0.16ms
tip-of-tree
tip-of-tree		761.56ms - 771.12msunsure 🔍
-0% - +1%
-3.07ms - +10.25ms		-unsure 🔍
-1% - +0%
-10.78ms - +3.85ms
previous-release
previous-release		764.27ms - 775.34msunsure 🔍
-0% - +2%
-0.16ms - +14.27ms		unsure 🔍
-1% - +1%
-3.85ms - +10.78ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
758.31ms - 766.28ms-faster ✔
0% - 2%
2.52ms - 14.45ms		unsure 🔍
-1% - +1%
-6.48ms - +5.52ms
tip-of-tree
tip-of-tree		766.34ms - 775.22msslower ❌
0% - 2%
2.52ms - 14.45ms		-slower ❌
0% - 2%
1.69ms - 14.32ms
previous-release
previous-release		758.29ms - 767.26msunsure 🔍
-1% - +1%
-5.52ms - +6.48ms		faster ✔
0% - 2%
1.69ms - 14.32ms		-

tachometer-reporter-action v2 for Benchmarks

AndrewJakubowicz
AndrewJakubowicz reviewed May 5, 2023
View reviewed changes
@usergenic usergenic merged commit 2684dd6 into main May 8, 2023
@usergenic usergenic deleted the virtualizer-tsstyle branch May 8, 2023 21:16
rictic pushed a commit that referenced this pull request May 9, 2023
@usergenic @rictic
Add missing license headers to files to placate the compliance checks. (
1c0d1a1 
#3884)

* Add missing license headers to files to placate the compliance checks.
* Backdate licenses to 2021, the file creation year.
@usergenic usergenic changed the title Add missing license headers to files to placate the compliance checks. [labs/virtualizer ]Add missing license headers to files to placate the compliance checks. May 10, 2023
@usergenic usergenic changed the title [labs/virtualizer ]Add missing license headers to files to placate the compliance checks. [labs/virtualizer] Add missing license headers to files to placate the compliance checks. May 10, 2023
@lit-robot lit-robot mentioned this pull request May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

@AndrewJakubowicz AndrewJakubowicz AndrewJakubowicz approved these changes

@graynorton graynorton Awaiting requested review from graynorton

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@usergenic @justinfagnani @AndrewJakubowicz