Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix a memory leak with the shared TreeWalker #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinfagnani merged 2 commits into from
May 9, 2023
Merged

Fix a memory leak with the shared TreeWalker #3888

justinfagnani merged 2 commits into from
May 9, 2023

Conversation

@justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented May 9, 2023

We weren't resetting the currentNode of the shared TreeWalker after either template prep or template cloning. This caused the TreeWalker to hold on to the last currentNode of the last tree walk.

This should always be after a clone because I can't think of a situation where we prep a template but don't immediately render it. So for the fix I set currentNode after a template clone. You can't set TreeWalker.currentNode to null, so I set it to the document.

@justinfagnani justinfagnani requested a review from rictic May 9, 2023 16:45
@changeset-bot
Copy link

changeset-bot bot commented May 9, 2023

🦋 Changeset detected

Latest commit: e112cf3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
lit-html Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -2% - +8% (-0.42ms - +1.50ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 89.72ms - 93.45ms
  • lit-html-kitchen-sink: unsure 🔍 -2% - +10% (-0.65ms - +3.56ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -11% - +9% (-1.40ms - +1.18ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +2% (-2.09ms - +1.57ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -3% - +4% (-1.75ms - +2.34ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 921.82ms - 931.64ms
  • lit-html-kitchen-sink: unsure 🔍 -5% - +3% (-5.16ms - +3.04ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -9% - +15% (-32.95ms - +52.38ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +1% (-3.56ms - +1.71ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-7.12ms - +11.25ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 886.41ms - 896.97ms
  • reactive-element-list: unsure 🔍 -1% - +1% (-12.10ms - +6.43ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
89.72ms - 93.45ms-

update

VersionAvg timevs
921.82ms - 931.64ms-

update-reflect

VersionAvg timevs
886.41ms - 896.97ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
35.31ms - 38.44ms-unsure 🔍
-2% - +10%
-0.65ms - +3.56ms		unsure 🔍
-5% - +8%
-1.95ms - +2.87ms
tip-of-tree
tip-of-tree		34.01ms - 36.83msunsure 🔍
-10% - +2%
-3.56ms - +0.65ms		-unsure 🔍
-9% - +4%
-3.31ms - +1.32ms
previous-release
previous-release		34.58ms - 38.25msunsure 🔍
-8% - +5%
-2.87ms - +1.95ms		unsure 🔍
-4% - +9%
-1.32ms - +3.31ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
89.26ms - 95.76ms-unsure 🔍
-5% - +3%
-5.16ms - +3.04ms		unsure 🔍
-7% - +2%
-6.90ms - +1.92ms
tip-of-tree
tip-of-tree		91.07ms - 96.06msunsure 🔍
-3% - +6%
-3.04ms - +5.16ms		-unsure 🔍
-6% - +3%
-5.32ms - +2.46ms
previous-release
previous-release		92.02ms - 97.98msunsure 🔍
-2% - +8%
-1.92ms - +6.90ms		unsure 🔍
-3% - +6%
-2.46ms - +5.32ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
19.43ms - 20.70ms-unsure 🔍
-2% - +8%
-0.42ms - +1.50ms		unsure 🔍
-2% - +6%
-0.41ms - +1.13ms
tip-of-tree
tip-of-tree		18.81ms - 20.25msunsure 🔍
-7% - +2%
-1.50ms - +0.42ms		-unsure 🔍
-5% - +3%
-1.02ms - +0.66ms
previous-release
previous-release		19.27ms - 20.14msunsure 🔍
-6% - +2%
-1.13ms - +0.41ms		unsure 🔍
-3% - +5%
-0.66ms - +1.02ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
12.16ms - 13.48ms-unsure 🔍
-11% - +9%
-1.40ms - +1.18ms		unsure 🔍
-6% - +8%
-0.70ms - +1.03ms
tip-of-tree
tip-of-tree		11.82ms - 14.04msunsure 🔍
-9% - +11%
-1.18ms - +1.40ms		-unsure 🔍
-8% - +12%
-0.96ms - +1.51ms
previous-release
previous-release		12.10ms - 13.21msunsure 🔍
-8% - +5%
-1.03ms - +0.70ms		unsure 🔍
-12% - +7%
-1.51ms - +0.96ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
339.68ms - 401.45ms-unsure 🔍
-9% - +15%
-32.95ms - +52.38ms		unsure 🔍
-12% - +10%
-46.41ms - +37.71ms
tip-of-tree
tip-of-tree		331.41ms - 390.28msunsure 🔍
-14% - +9%
-52.38ms - +32.95ms		-unsure 🔍
-14% - +7%
-55.07ms - +26.93ms
previous-release
previous-release		346.37ms - 403.46msunsure 🔍
-10% - +13%
-37.71ms - +46.41ms		unsure 🔍
-8% - +15%
-26.93ms - +55.07ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
65.66ms - 68.30ms-unsure 🔍
-3% - +2%
-2.09ms - +1.57ms		unsure 🔍
-2% - +3%
-1.50ms - +2.14ms
tip-of-tree
tip-of-tree		65.98ms - 68.51msunsure 🔍
-2% - +3%
-1.57ms - +2.09ms		-unsure 🔍
-2% - +4%
-1.20ms - +2.37ms
previous-release
previous-release		65.41ms - 67.92msunsure 🔍
-3% - +2%
-2.14ms - +1.50ms		unsure 🔍
-4% - +2%
-2.37ms - +1.20ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
136.64ms - 140.28ms-unsure 🔍
-3% - +1%
-3.56ms - +1.71ms		unsure 🔍
-3% - +1%
-3.75ms - +1.58ms
tip-of-tree
tip-of-tree		137.48ms - 141.30msunsure 🔍
-1% - +3%
-1.71ms - +3.56ms		-unsure 🔍
-2% - +2%
-2.89ms - +2.57ms
previous-release
previous-release		137.60ms - 141.49msunsure 🔍
-1% - +3%
-1.58ms - +3.75ms		unsure 🔍
-2% - +2%
-2.57ms - +2.89ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
57.67ms - 60.67ms-unsure 🔍
-3% - +4%
-1.75ms - +2.34ms		unsure 🔍
-7% - +0%
-4.11ms - +0.19ms
tip-of-tree
tip-of-tree		57.49ms - 60.26msunsure 🔍
-4% - +3%
-2.34ms - +1.75ms		-faster ✔
0% - 7%
0.19ms - 4.33ms
previous-release
previous-release		59.59ms - 62.67msunsure 🔍
-0% - +7%
-0.19ms - +4.11ms		slower ❌
0% - 7%
0.19ms - 4.33ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
961.76ms - 974.26ms-unsure 🔍
-1% - +1%
-7.12ms - +11.25ms		unsure 🔍
-1% - +1%
-9.50ms - +9.88ms
tip-of-tree
tip-of-tree		959.21ms - 972.67msunsure 🔍
-1% - +1%
-11.25ms - +7.12ms		-unsure 🔍
-1% - +1%
-11.88ms - +8.13ms
previous-release
previous-release		960.42ms - 975.22msunsure 🔍
-1% - +1%
-9.88ms - +9.50ms		unsure 🔍
-1% - +1%
-8.13ms - +11.88ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
943.02ms - 956.62ms-unsure 🔍
-1% - +1%
-12.10ms - +6.43ms		unsure 🔍
-1% - +1%
-11.04ms - +9.13ms
tip-of-tree
tip-of-tree		946.35ms - 958.96msunsure 🔍
-1% - +1%
-6.43ms - +12.10ms		-unsure 🔍
-1% - +1%
-7.88ms - +11.64ms
previous-release
previous-release		943.32ms - 958.23msunsure 🔍
-1% - +1%
-9.13ms - +11.04ms		unsure 🔍
-1% - +1%
-11.64ms - +7.88ms		-

tachometer-reporter-action v2 for Benchmarks

@rictic
Copy link
Collaborator

rictic commented May 9, 2023

Nice!

@justinfagnani justinfagnani merged commit 0f30e6f into main May 9, 2023
@justinfagnani justinfagnani deleted the walker-leak branch May 9, 2023 17:30
@lit-robot lit-robot mentioned this pull request May 11, 2023
Merged
@AndrewJakubowicz AndrewJakubowicz mentioned this pull request May 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rictic rictic rictic approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justinfagnani @rictic