Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/react] Only add suppressHydrationWarning prop in the client #3978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
augustjk merged 2 commits into from
Jun 26, 2023
Merged

[labs/react] Only add suppressHydrationWarning prop in the client #3978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb96896
Only add suppressHydrationWarning prop in client
augustjk Jun 23, 2023
ac82698
Add changeset
augustjk Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/calm-deers-hope.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@lit-labs/react': patch
---

Only add `suppressHydrationWarning` prop when rendered in the client. This will prevent `suppresshydrationwarning` attribute being added to the host element when using `@lit-labs/ssr-react`.
8 changes: 5 additions & 3 deletions packages/labs/react/src/create-component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,9 +371,11 @@ the element.`);
return createElement<React.HTMLAttributes<I>, I>(tag, props);
}

// Suppress hydration warning for server-rendered attributes, including
// "defer-hydration"
props['suppressHydrationWarning'] = true;
if (!NODE_MODE) {
// Suppress hydration warning for server-rendered attributes, including
// "defer-hydration"
props['suppressHydrationWarning'] = true;
}

return createElement<React.HTMLAttributes<I>, I>(tag, props);
}
Expand Down