server: Allow custom path to front-end assets (#1077) #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitnelave
reviewed
Jan 17, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1079 +/- ##
==========================================
+ Coverage 85.75% 86.29% +0.53%
==========================================
Files 50 51 +1
Lines 11103 11488 +385
==========================================
+ Hits 9521 9913 +392
+ Misses 1582 1575 -7
|
4276e88 to
0fb472e
Compare
|
I think I've addressed your comments. Is this closer to what you wanted? |
nitnelave
approved these changes
Jan 21, 2025
a9d77d1 to
ef2af48
Compare
|
Yes, I tested it with a custom path as well as the default and it works as expected. Thanks! |
bc3f7d9 to
21879a9
Compare
21879a9 to
43d08e9
Compare
|
Hi! Is there anything else I need to do to get this merged? |
|
Sorry, I meant to merge it earlier, let me try to do this tonight. |
|
Or, you know, right now |
broeng
added a commit
to broeng/lldap
that referenced
this pull request
Jan 29, 2025
Had changed behaviour to serve the gz compressed wasm package with the uncompressed handler.
broeng
added a commit
to broeng/lldap
that referenced
this pull request
Jan 29, 2025
Had changed behaviour to serve the gz compressed wasm package with the uncompressed handler.
nitnelave
pushed a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows the user to specify a custom path to the front-end assets with either the LLDAP_ASSETS_PATH environment variable or the assets_path config option. This should make lldap more pleasant for maintainers to package properly.
Addresses issue #1077