Conversation
nitnelave
reviewed
Jan 3, 2023
Member
|
Thanks! A minor nit, but anyway this is nice even as-is. |
pixelrazor
commented
Jan 3, 2023
Member
|
Thanks, that looks better! I'm no expert on VS code containers, so I'll trust you that it works. Last nit: can you add |
Collaborator
Author
Done. I added |
nitnelave
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #331
The dockerfile could probably be optimized - i just tinkered until i got something that wants to work out the box. the cargo install step is pretty hefty, so i COULD try to tinker with making that a separate layer as early as possible to help cache it, but i don't think it's too important given this shouldn't change often at all.