-
Notifications
You must be signed in to change notification settings - Fork 110
Migrate CI to use GitLab Components from radiuss-shared-ci #1935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adrienbernede
wants to merge
20
commits into
develop
Choose a base branch
from
woptim/rsci-migrate-to-components
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+379
−339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit migrates the RAJA CI configuration from the template-based approach to GitLab CI Components (requires GitLab 17.0+). Components provide better versioning, type-safe inputs, and cleaner syntax. Changes: - Update .gitlab-ci.yml to use components from radiuss-shared-ci: - base-pipeline component for core functionality and .machine-check template - utility-draft-pr-filter component for draft PR handling - Machine-specific pipeline components (dane, matrix, corona, tioga, tuolumne) - Split custom-jobs-and-variables.yml into separate files: - custom-jobs.yml: Job templates for child pipelines - custom-variables.yml: Machine-specific allocation variables - Consolidate machine pipeline definitions into main .gitlab-ci.yml - Remove .gitlab/subscribed-pipelines.yml (replaced by inline definitions) - Add RADIUSS_SHARED_CI_REF variable to specify component version - Update copyright year to 2025 The old custom-jobs-and-variables.yml file is retained for backward compatibility but is no longer referenced by the CI configuration. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
This reverts commit 55e2b43.
This reverts commit 55e2b43.
BUILD_ROOT was being set to ${CI_PROJECT_DIR} but this causes issues
when passed as a component input because CI_PROJECT_DIR doesn't exist
when inputs are resolved. The variable is not actually needed since
CI jobs run in the project directory by default.
Projects can define BUILD_ROOT locally if their build scripts need it,
but it shouldn't be passed to components as an input.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
53c51c0 to
bd52c25
Compare
Update docs/sphinx/dev_guide/ci.rst to reflect the migration from template-based CI to GitLab CI Components: - Updated .gitlab-ci.yml description to mention it now uses GitLab CI Components (requires GitLab 17.0+) - Replaced references to subscribed-pipelines.yml and custom-jobs-and-variables.yml with the new split files: - custom-jobs.yml - Job templates for child pipelines - custom-variables.yml - Machine-specific allocation variables - Clarified that these files are created and customized by each project based on templates from RADIUSS Shared CI - Updated pipeline launching section to explain component syntax and list available components (base-pipeline, utility-draft-pr-filter, machine-specific pipelines) - Explained that machine pipelines are now defined inline in .gitlab-ci.yml using trigger syntax with component includes
…tion Update docs/sphinx/dev_guide/ci_tasks.rst to reflect the migration from template-based CI to GitLab CI Components: - Updated run parameters section to reference custom-variables.yml and custom-jobs.yml instead of the old custom-jobs-and-variables.yml file - Clarified that these files are created and customized by each project for its specific needs - Updated RAJAPerf CI section to reflect the new file structure and mention that it uses GitLab CI Components from radiuss-shared-ci - Removed references to subscribed-pipelines.yml which no longer exists
Member
Author
|
@rhornung67 This PR is now ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit migrates the RAJA CI configuration from the template-based approach to GitLab CI Components (requires GitLab 17.0+). Components provide better versioning, type-safe inputs, and cleaner syntax.
Changes:
The old custom-jobs-and-variables.yml file is retained for backward compatibility but is no longer referenced by the CI configuration.
TODO: