Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add option to control sync of draft PRs #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cmelone wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add option to control sync of draft PRs #190

cmelone wants to merge 2 commits into from

Conversation

@cmelone
Copy link
Member

@cmelone cmelone commented Nov 17, 2025

Repository maintainers can specify True/False under Repo -> sync_drafts in .github/hubcast.yml.

Once the Gitlab as a source forge PR is merged we can integrate this option.

@cmelone
Add option to control sync of draft PRs
588f8ab 
Repository maintainers can specify True/False under Repo -> `sync_drafts` in `.github/hubcast.yml`.

Once the Gitlab as a source forge PR is merged we can integrate this
option.
@cmelone cmelone requested a review from alecbcs November 17, 2025 22:21
alecbcs
alecbcs reviewed Dec 3, 2025
View reviewed changes
Copy link
Member

@alecbcs alecbcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me pending bot functionality comments when not being synced.

@cmelone
Copy link
Member Author

cmelone commented Dec 3, 2025

I'll implement that right now, I have no idea why I wrote that comment considering it's been in for a few months 😅

@alecbcs
Copy link
Member

alecbcs commented Dec 4, 2025

No worries haha :)

@cmelone
Copy link
Member Author

cmelone commented Dec 4, 2025

To avoid handling past comments when the status of a PR changes, we also have a couple alternatives:

  • like the current spack sync script, post a neutral status check saying it won't be synced until it's off draft status
  • set a label on the PR like hubcast-skipped or something but repo maintainers might not like this and it doesn't really explain anything

@alecbcs
Copy link
Member

alecbcs commented Dec 10, 2025 •
edited
Loading

I'd vote for the 1st option, but let's make it optional via a config. Some users might want to disable draft PRs and not get a message from Hubcast while others probably do want a place holder status check with a message.

@cmelone
Add option (draft_sync_msg, default=True) to set a status check of
71ffa0c 
"skipped" for draft PRs where sync was skipped. Rewrote a bit of `set_check_status` to allow setting a title-only status check.
@cmelone
Copy link
Member Author

cmelone commented Dec 12, 2025

I'd vote for the 1st option, but let's make it optional via a config. Some users might want to disable draft PRs and not get a message from Hubcast while others probably do want a place holder status check with a message.

implemented in 71ffa0c

@cmelone cmelone requested a review from alecbcs December 12, 2025 22:51
@cmelone cmelone enabled auto-merge (squash) December 12, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alecbcs alecbcs Awaiting requested review from alecbcs

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmelone @alecbcs