Replaced 'replicate' to correctly named 'replace' flags #7442
Conversation
…ceSequentialMemories per issue llvm#7384
|
@jpien13 you are failing the code formatting check. See Line 239 in bec0dea Or even better you can get clang-format working in your environment, the formatting configuration file is included in the repo. |
lib/Firtool/Firtool.cpp
Outdated
|
|
||
| pm.nest<firrtl::CircuitOp>().addPass( | ||
| firrtl::createMemToRegOfVecPass(opt.shouldReplicateSequentialMemories(), | ||
| firrtl::createMemToRegOfVecPass(opt.shouldReplaceSequentialMemories(), |
There was a problem hiding this comment.
the formatter doesn't like the trailing whitespace at the end of this line
There was a problem hiding this comment.
Hi Megan! Yea i just saw this, i made the change just now. Had to install the clang formatter. Should be good now? We'll see what CI job says
There was a problem hiding this comment.
I'll have to doublecheck the config file, I didn't see your comments till now (before I pushed the newest change to get rid of the whitespace). I'll check my settings and formatting now. Thanks :)
**EDIT: found the .clang-format file, all set.
|
LGTM! @youngar can this be merged? I don't have permissions to do so. |
|
Thanks @jpien13! |
Renamed and replaced shouldReplicateSequentialMemories to shouldReplaceSequentialMemories per issue #7384
MLIR Tests:
[0/1] Running the MLIR regression tests
Testing Time: 53.62s
Total Discovered Tests: 2877
Unsupported : 506 (17.59%)
Passed : 2370 (82.38%)
Expectedly Failed: 1 (0.03%)
CIRCT Tests:
[0/1] Running the CIRCT regression tests
Testing Time: 12.50s
Total Discovered Tests: 824
Unsupported : 21 (2.55%)
Passed : 797 (96.72%)
Expectedly Failed: 6 (0.73%)
CIRCT integration tests:
[1/2] Running the CIRCT integration tests
Testing Time: 15.29s
Total Discovered Tests: 98
Unsupported : 63 (64.29%)
Passed : 34 (34.69%)
Expectedly Failed: 1 (1.02%)