Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@uenoku
Copy link
Member

@uenoku uenoku commented Aug 7, 2024

This commit adds a new lowering option to sanitize empty modules by creating a dummy wire in it.

@uenoku uenoku requested a review from prithayan August 7, 2024 07:10
This commit adds a new lowering option to sanitize empty modules by
creating a dummy wire in it.
@uenoku uenoku force-pushed the dev/hidetou/empty-modules branch from 26a48f4 to 777f937 Compare August 7, 2024 07:12
Copy link
Contributor

@prithayan prithayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hideto for this fix. LGTM.

Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I remember this coming up in various synthesis tools 🙈

@uenoku uenoku merged commit a943626 into main Aug 8, 2024
@uenoku uenoku deleted the dev/hidetou/empty-modules branch August 8, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants