Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SCFToCalyx] Build control for nested if operation #7669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

[SCFToCalyx] Build control for nested if operation #7669

merged 1 commit into from
Oct 31, 2024

Conversation

@jiahanxie353
Copy link
Contributor

@jiahanxie353 jiahanxie353 commented Oct 6, 2024 •
edited
Loading

This patch supports BuildControl for nested scf::If operations

@jiahanxie353 jiahanxie353 added the Calyx The Calyx dialect label Oct 6, 2024
@jiahanxie353 jiahanxie353 mentioned this pull request Oct 6, 2024
Merged
@rachitnigam
Copy link
Contributor

PR needs description. Please add one and then tag reviewers!

@jiahanxie353 jiahanxie353 self-assigned this Oct 31, 2024
cgyurgyik
cgyurgyik reviewed Oct 31, 2024
View reviewed changes
cgyurgyik
cgyurgyik approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@cgyurgyik cgyurgyik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jiahanxie353 jiahanxie353 merged commit 6405aa7 into llvm:main Oct 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgyurgyik cgyurgyik cgyurgyik approved these changes

@mikeurbach mikeurbach Awaiting requested review from mikeurbach

@mortbopet mortbopet Awaiting requested review from mortbopet

@rachitnigam rachitnigam Awaiting requested review from rachitnigam rachitnigam is a code owner

Assignees

@jiahanxie353 jiahanxie353

Labels

Calyx The Calyx dialect

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jiahanxie353 @rachitnigam @cgyurgyik