[MooreToCore] Add support for moore::string_constant #7628 #7752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
reviewed
Oct 31, 2024
Comment on lines
875
to
878
| // CHECK: hw.constant 1415934836 | ||
| %str = moore.string_constant "Test" : i2 | ||
| // CHECK: hw.constant 0 | ||
| %str_empty = moore.string_constant "" : i128 |
There was a problem hiding this comment.
Maybe add the : i2 and : i128 type suffices to the CHECK lines, to make sure the conversion does the right thing.
There was a problem hiding this comment.
Done. Corrected types as mentioned above and added type suffixes to the CHECK lines.
52e413f to
19a4bfa
Compare
fabianschuiki
approved these changes
Nov 4, 2024
Lower string constant ops to constant op in the hw dialect.
19a4bfa to
6e5adeb
Compare
|
Really nice! @jpinot If you want, feel free to get commit access to CIRCT to merge the PR yourself, or let me know if I should land it for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower
StringConstantOptohw::ConstantOp. Encodes strings asAPIntwith byte-width based on string length, enabling representation of Moore string constant as bit vectors.