[FIRRTL] Remove all traces of OMIR JSON support. #7907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This legacy system for representing an object model has been replaced by FIRRTL classes, objects, and properties. This removes the old system completely. The main change is removing the EmitOMIR pass completely, but there are several other things related to OMIR JSON to clean up. This includes command line options and annotations for specifying input and output OMIR JSON, as well as support for parsing the JSON and scattering OMIR tracker annotations. Any tests related to the above were also removed. The only remaining legacy OMIR feature is the OMIRTracker annotation, which is currently used by ResolvePaths and several passes. As we rolled out the FIRRTL property support, we chose to re-use this annotation for representing targets, so this is the one piece of the old system that we have to keep for now.
seldridge
approved these changes
Nov 26, 2024
| constexpr const char *omirFileAnnoClass = | ||
| "freechips.rocketchip.objectmodel.OMIRFileAnnotation"; | ||
| constexpr const char *omirTrackerAnnoClass = | ||
| "freechips.rocketchip.objectmodel.OMIRTracker"; |
There was a problem hiding this comment.
This can also go. If you don't handle it in this PR, I can deal with with it in a follow-on.
This does mean that the shouldBeDeleted (or can be) function needs to be updated.
There was a problem hiding this comment.
Yep, I'll pull this thread
There was a problem hiding this comment.
This is now going deeper than I wanted... I'm starting to look at the changes to IMDCE and I'm nervous I've missed something... So, I broke it out and I've sent a draft PR here, based on this branch for now: #7908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This legacy system for representing an object model has been replaced by FIRRTL classes, objects, and properties. This removes the old system completely.
The main change is removing the EmitOMIR pass completely, but there are several other things related to OMIR JSON to clean up. This includes command line options and annotations for specifying input and output OMIR JSON, as well as support for parsing the JSON and scattering OMIR tracker annotations. Any tests related to the above were also removed.