[circt-bmc][VerifToSMT] Add initial value support #7903
Merged
+78
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maerhart
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
LGTM! Very nice that these examples work properly now. 🎉
I think we should change the assembly format of the bmc op a bit in the future. It's a bit confusing to see which of the block arguments and terminator operands are regular inputs/outputs, registers, state values, etc.
001de91 to
5d84f46
Compare
…rovided for integer regs and update tests accordingly
bb54e67 to
da1688e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes circt-bmc to use the initial values added to the BMC op in #7729 to initialize register states - this should mean circt-bmc can now check meaningful properties! 🎉
The added integration test checks whether the counter value always stays below a certain value with different time bounds, which also functions as a check that assertions are getting popped as mentioned in #7900