[RTGTest] Add some registers #7924
Conversation
| Virtual registers will be assigned a concrete register when running register | ||
| allocation. |
There was a problem hiding this comment.
This probably doesn't make sense for a test dialect, but in practice, would you have virtual registers as a separate op that cannot be CSEd, and actual ISA register as something "pure" or maybe even "constant-like"?
There was a problem hiding this comment.
Good point! Having concrete registers CSE would be very nice. Having separate ops for concrete and virtual registers complicates register allocation a bit but makes elaboration easier. Let me think about that a bit more.
|
|
||
| // Flat allocation of unique IDs to all registers. The actual ID value does not | ||
| // matter. | ||
| def RegisterAttr : I32EnumAttr< |
There was a problem hiding this comment.
I think ideally this attribute should be of IntegerRegisterType, not I32. It's not a big deal for now though.
31e652b to
81f191f
Compare
This adds some registers to later test passes such as register alloction, assembly emission, correct behavior of the elaboration pass in presence of registers, etc. Co-authored-by: Andrew Lenharth <[email protected]>
49fccfd to
d868ec9
Compare
|
I'll merge this as-is for now and will follow up with another PR to fix the above two points. |
This adds some registers to later test passes such as register alloction, assembly emission, correct behavior of the elaboration pass in presence of registers, etc.