Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@TaoBi22
Copy link
Contributor

@TaoBi22 TaoBi22 commented Nov 29, 2024

Tiny change, just makes it so VerifToSMT exits early after throwing the too many clocks error (rather than still trying to apply the pass).

@TaoBi22 TaoBi22 requested a review from maerhart November 29, 2024 14:54
Copy link
Member

@maerhart maerhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

if (numClockArgs > 1) {
op->emitError(
"only modules with one or zero clocks are currently supported");
signalPassFailure();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
signalPassFailure();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks!

@TaoBi22 TaoBi22 merged commit 44a38c4 into llvm:main Nov 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants