[firtool] Add an option to disable CSE in classes #7931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
approved these changes
Dec 2, 2024
seldridge
reviewed
Dec 2, 2024
d6ee776 to
b442451
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to run CSE only on
firrtl.module, and ignore everything else.There are some tools, that are not able to handle CSE of
firrtl.objectinfirrtl.class.Specifically, the reuse of
firrtl.objectis not modeled properly.This is a temporary workaround to disable the CSE of operations inside
firrtl.class, which can be removed once the actual issue in the tool is fixed.