[FIRRTL] Clock gate extraction work w/ prefixing #7946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weaken the check used by the `ExtractInstances` pass to determine what is a clock gate. Change this from requiring that the defname of an external module is exactly "EICG_wrapper" to instead only needing to end with "EICG_wrapper". This is done so that this will work with Chisel-time prefixing and that we would actually _like_ to prefix these clock gates. Commentary: this string matching is terrible. I realize that. However, this is a legacy API that is intending to be replaced. Signed-off-by: Schuyler Eldridge <[email protected]>
mwachs5
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weaken the check used by the
ExtractInstancespass to determine what is a clock gate. Change this from requiring that the defname of an external module is exactly "EICG_wrapper" to instead only needing to end with "EICG_wrapper". This is done so that this will work with Chisel-time prefixing and that we would actually like to prefix these clock gates.Commentary: this string matching is terrible. I realize that. However, this is a legacy API that is intending to be replaced.