[LowerTypes] Copy discardable attributes when cloning operations #7948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
approved these changes
Dec 4, 2024
Comment on lines
-1505
to
+1508
| // Copy over any attributes which have not already been copied over by | ||
| // arguments to the builder. | ||
| auto attrNames = InstanceOp::getAttributeNames(); | ||
| DenseSet<StringRef> attrSet(attrNames.begin(), attrNames.end()); | ||
| SmallVector<NamedAttribute> newAttrs(newInstance->getAttrs()); | ||
| for (auto i : llvm::make_filter_range(op->getAttrs(), [&](auto namedAttr) { | ||
| return !attrSet.count(namedAttr.getName()); | ||
| })) | ||
| newAttrs.push_back(i); | ||
| newInstance->setAttrs(newAttrs); | ||
| newInstance->setDiscardableAttrs(op->getDiscardableAttrDictionary()); |
There was a problem hiding this comment.
This is nice cleanup as it should avoid re-interning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes to clone discardable attributes when operation is cloned.
Fix #7934. AttributeAnnotation adds
sv.attributesin LowerAnnotation as a discardable attribute which previously LowerTypes dropped.