Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SCFToCalyx] buildLibraryOp cast floating point to integer types #7977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 13, 2024
Merged

[SCFToCalyx] buildLibraryOp cast floating point to integer types #7977

merged 3 commits into from
Dec 13, 2024

Conversation

@jiahanxie353
Copy link
Contributor

In buildLibraryOp, we cast floating point types to integer types with the same width, as discussed here: #7762

The testing case is just the result of running the -arith-expand pass on the following input:

module {
  func.func @main(%b: f64, %c: f64) -> f64 {
    %a = arith.maximumf %b, %c : f64
    return %a : f64
  }
}

@jiahanxie353 jiahanxie353 self-assigned this Dec 12, 2024
@jiahanxie353 jiahanxie353 added the Calyx The Calyx dialect label Dec 12, 2024
cgyurgyik
cgyurgyik reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@cgyurgyik cgyurgyik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits :)

@jiahanxie353
buildLibraryOp cast floating point to integer types
d63b302
@jiahanxie353
make toBitVector a template and add a test case with signed integer t…
f3d5bec 
…ype; enable build return arguments with signed integer type by making convIndexType to a more generic normalize type function
@jiahanxie353
Copy link
Contributor Author

Thanks @cgyurgyik !

Made some changes based on your feedback; also changed convIndex to a more generic function by utilizing the toBitVector function.

cgyurgyik
cgyurgyik approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@cgyurgyik cgyurgyik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@jiahanxie353 @cgyurgyik
fix typos
b6fb326 
Co-authored-by: Chris Gyurgyik <[email protected]>
@jiahanxie353 jiahanxie353 merged commit 5ef9ea9 into llvm:main Dec 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgyurgyik cgyurgyik cgyurgyik approved these changes

@mikeurbach mikeurbach Awaiting requested review from mikeurbach

@mortbopet mortbopet Awaiting requested review from mortbopet

@rachitnigam rachitnigam Awaiting requested review from rachitnigam rachitnigam is a code owner

@andrewb1999 andrewb1999 Awaiting requested review from andrewb1999 andrewb1999 is a code owner

Assignees

@jiahanxie353 jiahanxie353

Labels

Calyx The Calyx dialect

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jiahanxie353 @cgyurgyik