Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[RTG][Elaboration] Add support for 'index.add' and 'index.cmp' #7978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2025
Merged

[RTG][Elaboration] Add support for 'index.add' and 'index.cmp' #7978

merged 1 commit into from
Jan 14, 2025

Conversation

@maerhart
Copy link
Member

  • Use the index dialect instead of arith because it is a smaller dependency and simpler, but still has everything we need.
  • Add support for index.add and index.cmp
  • Add specialized elaborator values for indices and booleans because creating attributes for intermediates is quite bad performance-wise (ideally we'd have some evaluation interface at some point that we can also use for folding, or better folders that we can call directly)

@maerhart maerhart added the RTG Involving the `rtg` dialect label Dec 12, 2024
darthscsi
darthscsi reviewed Dec 17, 2024
View reviewed changes
lib/Dialect/RTG/Transforms/ElaborationPass.cpp
namespace {

/// The abstract base class for elaborated values.
struct ElaboratorValue {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like just a std::variant.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll address this in #7997

darthscsi
darthscsi approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@darthscsi darthscsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the elaboration is reinventing std::variant, but that is separate from this PR.

@maerhart maerhart force-pushed the maerhart-rtg-elaboration-sequences branch from 75e65f4 to 1d5640f Compare January 14, 2025 19:59
Base automatically changed from maerhart-rtg-elaboration-sequences to main January 14, 2025 20:28
@maerhart maerhart force-pushed the maerhart-rtg-elaboration-indexops branch from eda599f to 83c12d2 Compare January 14, 2025 21:00
@maerhart maerhart merged commit fff227c into main Jan 14, 2025
4 checks passed
@maerhart maerhart deleted the maerhart-rtg-elaboration-indexops branch January 14, 2025 21:51
TaoBi22 pushed a commit to TaoBi22/circt that referenced this pull request Jul 17, 2025
@maerhart @TaoBi22
[RTG][Elaboration] Add support for 'index.add' and 'index.cmp' (llvm#…
7412ace 
…7978)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darthscsi darthscsi darthscsi approved these changes

@rwy7 rwy7 Awaiting requested review from rwy7

@youngar youngar Awaiting requested review from youngar

Assignees

No one assigned

Labels

RTG Involving the `rtg` dialect

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maerhart @darthscsi