Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@seldridge
Copy link
Member

Add a preliminary ViewIntrinsic that is an intended replacement for the Grand Central View AugmentedBundleType Annotation.

@seldridge seldridge requested a review from dtzSiFive January 3, 2025 00:18
@dtzSiFive
Copy link
Contributor

I tweaked the operation a little, LGTM re:op addition.

Needs entry in FIRRTLVisitor (Statement?).

Verification might be reasonable to add to the operation, depending on how big these get (mostly sanity checking the attribute and that operand count matches, I think)?

While these have (and introduce a name, as a sort of declaration) they aren't expected to really act that way, I think is where things landed.
(can't target with annotations, so on)

seldridge and others added 5 commits January 16, 2025 12:41
Add a preliminary ViewIntrinsic that is an intended replacement for the
Grand Central View AugmentedBundleType Annotation.

Signed-off-by: Schuyler Eldridge <[email protected]>
@dtzSiFive dtzSiFive force-pushed the dev/seldridge/firrtl-view-intrinsic branch from 5afc03a to f806d5c Compare January 16, 2025 18:49
@dtzSiFive dtzSiFive marked this pull request as ready for review January 16, 2025 18:50
@dtzSiFive dtzSiFive requested a review from darthscsi as a code owner January 16, 2025 18:50
@dtzSiFive
Copy link
Contributor

(CI failure will be fixed by in-flight PR updating the artifact action)

I think this is good to go and a good starting point.

Copy link
Member Author

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A verifier (in a future PR) that checks the shape of the augmented bundle type and the number of variadic arguments would be nice.

@dtzSiFive
Copy link
Contributor

A verifier (in a future PR) that checks the shape of the augmented bundle type and the number of variadic arguments would be nice.

Yes! And maybe tweak the attributes to more directly contain what's needed (vs DictionaryAttr), reducing need to inspect their contents as part of the operation's verification other than minor details (and asking/counting how many leaves)...?

I'll tweak the operation to check all operands are ground types before merging 👍 .

@dtzSiFive dtzSiFive merged commit 701b9df into main Jan 16, 2025
4 checks passed
@dtzSiFive dtzSiFive deleted the dev/seldridge/firrtl-view-intrinsic branch January 16, 2025 20:07
TaoBi22 pushed a commit to TaoBi22/circt that referenced this pull request Jul 17, 2025
Add a preliminary ViewIntrinsic that is an intended replacement for the
Grand Central View AugmentedBundleType Annotation.

Signed-off-by: Schuyler Eldridge <[email protected]>
Co-authored-by: Will Dietz <[email protected]>
Co-authored-by: Schuyler Eldridge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants