[LoopScheduleToCalyx] deduplicate groups within a ParOp. #8055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeurbach
reviewed
Jan 9, 2025
It is not, that change avoids a use after free issue. I have not totally fixed the error yet though so going back to draft mode. (Edit: I agree with your sentiment. I'll follow up later) |
|
@mikeurbach I've updated this so that canonicalization isn't used as an "operation fixer-upper". |
mikeurbach
approved these changes
Jan 9, 2025
|
Thanks! This is branched off #8048 so if you have a chance to review that, it'd be great :-) |
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deduplicates multiple occurrences of the same Enable in a
ParOp. This can be introduced automatically by a compiler lowering phase, so we add this as a canonicalization pattern. Additionally, ensures that the pipeline register (and not the pipeline stage) is used in Calyx computation assignments.Fixes #8050.