[ESI] Add hostmem write support to cosim #8059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b29dfd to
5fa406f
Compare
5fa406f to
c4e3cb7
Compare
There was a problem hiding this comment.
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (4)
- lib/Dialect/ESI/runtime/cpp/lib/backends/Cosim.cpp: Language not supported
- lib/Dialect/ESI/runtime/cpp/tools/esitester.cpp: Language not supported
- frontends/PyCDE/test/test_esi.py: Evaluated as low risk
- frontends/PyCDE/src/pycde/signals.py: Evaluated as low risk
Comments suppressed due to low confidence (4)
frontends/PyCDE/src/pycde/bsp/common.py:339
- [nitpick] The variable name 'write_req_bundle_type' is ambiguous. It should be renamed to 'write_req_bundle_type_def' to clarify that it is a type definition.
write_req_bundle_type = esi.HostMem.write_req_bundle_type(data_type)
frontends/PyCDE/src/pycde/bsp/common.py:305
- The new functionality for handling write requests should be covered by tests to ensure it works as expected. Specifically, the behavior introduced in the 'build_tagged_write_mux' method should be tested.
def build_tagged_write_mux(ports, reqs: List[esi._OutputBundleSetter]) -> BundleSignal:
frontends/PyCDE/integration_test/esitester.py:130
- Ensure that cmd.offset is of type UInt(32) to avoid type mismatch errors.
write_loc_ce = mmio_xact & cmd.write & (cmd.offset == UInt(32)(0))
frontends/PyCDE/integration_test/esitester.py:127
- [nitpick] Improve the error message in cmd_chan_wire.unwrap to be more descriptive.
cmd, cmd_valid = cmd_chan_wire.unwrap(resp_ready_wire)
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
Adds cosim support to both the cosim BSP in PyCDE and the corresponding support in the runtime. As with hostmem reads, write only supports one client and no gearboxing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cosim support to both the cosim BSP in PyCDE and the corresponding support in the runtime. As with hostmem reads, write only supports one client and no gearboxing.