[SCFToCalyx] Re-initialize IRMapping at the start of each loop #8075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to merge it since the CI has passed and this patch does not introduce significant change. cc @cgyurgyik @rachitnigam @andrewb1999 |
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
…ion to map block arguments in region-based operations (llvm#8075)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses the issue with
IRMappingwhen unrolling the parallel loop during the SCFToCalyx pass. If there are region-based operations, such asscf.forinsidescf.parallel, the block arguments weren't cloned correctly because if we keep reusing the oldIRMapping, theIRMappingwill already have the entries from previous iterations that overshadows new ones. To fix it, we need to re-initialize theIRMappingevery iteration.