[SCFToCalyx] Lower scf.if op when it yields nothing
#8079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scf.if op it yields nothingscf.if op when it yields nothing
3c18cb7 to
9600512
Compare
cgyurgyik
approved these changes
Jan 14, 2025
Comment on lines
+1171
to
+1172
| return yieldOp.getOperation()->emitError() | ||
| << "Unsupported empty yieldOp outside ForOp or IfOp."; |
There was a problem hiding this comment.
Suggested change
| return yieldOp.getOperation()->emitError() | |
| << "Unsupported empty yieldOp outside ForOp or IfOp."; | |
| return "Unsupported empty yieldOp: " | |
| << yieldOp.getOperation()->emitError(); |
There was a problem hiding this comment.
I left this unchanged because I think we can only put << after emitError not infront
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch lowers
scf.ifOpwhen it has an empty yield/does not return any value.