[LowerFormalToHW] Avoid applyPatternsGreedily, NFCI
#8088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LowerFormalToHW used `applyPatternsGreedily` on ModuleOp but that is overkill for what LowerFormalToHW does. `applyPatternsGreedily` is called on ModuleOp so canonicalizations are executed in a single thread. This commit simply replaces RewriterPattern with a helper function and call it manually.
Seems like I messed up when replacing the code.
leonardt
approved these changes
Jan 15, 2025
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
LowerFormalToHW used `applyPatternsGreedily` on ModuleOp but that is overkill for what LowerFormalToHW does. `applyPatternsGreedily` is called on ModuleOp so canonicalizations are executed in a single thread. This commit simply replaces RewriterPattern with a helper function and call it manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LowerFormalToHW used
applyPatternsGreedilyon ModuleOp but that is overkill for what LowerFormalToHW does. SinceapplyPatternsGreedilyis called on ModuleOp, canonicalizations are executed in a single thread and LowerFormalToHW consumed non-trivial amount of time in large designs.This commit simply replaces RewriterPattern with a helper function and call it manually.
Should fix #8035.