Allow Bound-in layers under inline layers #8642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d28628 to
6b86340
Compare
seldridge
reviewed
Aug 6, 2025
There was a problem hiding this comment.
Very cool to see this work by just turning off the verifier.
I'd like to see one end-to-end test. Otherwise, LGTM.
Follow-on:
- Please open a PR to update this line in the FIRRTL spec: https://github.com/chipsalliance/firrtl-spec/blob/main/spec.md?plain=1#L255
| if (newInstance.getInnerSymAttr()) | ||
| if (auto forceName = circuitState.instanceForceNames.lookup( | ||
| {cast<hw::HWModuleOp>(newInstance->getParentOp()).getNameAttr(), | ||
| {newInstance->getParentOfType<hw::HWModuleOp>().getNameAttr(), |
There was a problem hiding this comment.
Nice cleanup. Always feel free to land this kind of change directly (especially since it is nicely factored into a separate commit!).
Comment on lines
-387
to
+392
| OpBuilder builder(layerBlock); | ||
| auto macroName = macroNames[layer]; | ||
| auto ifDef = sv::IfDefOp::create(builder, layerBlock.getLoc(), macroName); | ||
| ifDef.getBodyRegion().takeBody(layerBlock.getBodyRegion()); | ||
| if (!layerBlock.getBody()->empty()) { | ||
| OpBuilder builder(layerBlock); | ||
| auto macroName = macroNames[layer]; | ||
| auto ifDef = builder.create<sv::IfDefOp>(layerBlock.getLoc(), macroName); | ||
| ifDef.getBodyRegion().takeBody(layerBlock.getBodyRegion()); | ||
| } |
There was a problem hiding this comment.
Not creating the empty ifdefs unnecessarily seems good.
Out of curiosity, do we canonicalize these away in SV if they are empty today?
There was a problem hiding this comment.
Yep there is a canonicalizer.
6b86340 to
4f45330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the ability for "bind" layers to appear under "inline" layers.