[ESI] Add a transaction snoop operation #8684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a new transaction‐level snoop operation (snoop.xact) to the ESI dialect, lowers it to hardware, and wires it through the Python front end.
- Introduce
SnoopTransactionOpin ESIChannels.td withverifyandinferReturnTypesin ESIOps.cpp - Extend the HW lowering pass to remove
snoop.xactviaRemoveSnoopTransactionOp - Update MLIR tests and the PyCDE API (
snoop_xact) to exercise the new operation
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/Dialect/ESI/lowering.mlir | Add esi.snoop.xact examples and expected HW patterns |
| lib/Dialect/ESI/Passes/ESILowerToHW.cpp | Implement RemoveSnoopTransactionOp and plug into lowering passes |
| lib/Dialect/ESI/ESITypes.cpp | Exclude SnoopTransactionOp from channel‐use counts |
| lib/Dialect/ESI/ESIOps.cpp | Add verify and inferReturnTypes for SnoopTransactionOp |
| include/circt/Dialect/ESI/ESIChannels.td | Define SnoopTransactionOp with type inference |
| frontends/PyCDE/test/test_esi.py | Update lit checks to expect snoop.xact output |
| frontends/PyCDE/src/pycde/signals.py | Add snoop_xact method to Python API |
Comments suppressed due to low confidence (2)
frontends/PyCDE/src/pycde/signals.py:776
- [nitpick] The docstring for
snoop_xactshould mention that it returns both a transaction signal and the data value, and clarify their order to avoid confusion.
"""Combinationally snoop on the internal signals of a channel."""
lib/Dialect/ESI/Passes/ESILowerToHW.cpp:305
- [nitpick] The local variable
transactionis a bit generic; consider renaming it tofifoTransactionortransactionSignalfor consistency with the VR branch'svalidAndReady.
auto transaction = rewriter.create<comb::AndOp>(op.getLoc(), notEmpty,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new transaction‐level snoop operation (
snoop.xact) to the ESI dialect, lowers it to hardware, and wires it through the Python front end.SnoopTransactionOpin ESIChannels.td withverifyandinferReturnTypesin ESIOps.cppsnoop.xactviaRemoveSnoopTransactionOpsnoop_xact) to exercise the new operation