[HW] MaterializeConstant: check for null block #8687
Conversation
|
This was the root cause of a bug reported by a PyCDE user. In this case, it was triggered by the Problem with this bug is that I don't know how to craft a test for it! How would I create a test for it? |
There was a problem hiding this comment.
Pull Request Overview
Adds a guard in HWDialect::materializeConstant to check for a null block before dereferencing, preventing a potential segfault when no block is set.
- Cache
builder.getBlock()in a local variable and verify it’s non-null - Move the parent operation lookup and parameter expression handling inside the null check
Comments suppressed due to low confidence (1)
lib/Dialect/HW/HWDialect.cpp:105
- Add a unit test for calling
materializeConstantwith a builder that has no block to ensure it returnsnullptrinstead of crashing.
Block *block = builder.getBlock();
There was a problem hiding this comment.
LGTM, agree with copilot suggestion. For test probably you can create unittest under HW something like this https://github.com/llvm/circt/blob/2d75698c6396769afa084b80d133c4ad0532ed6d/unittests/Dialect/RTG/MaterializerTest.cpp.
I totally forgot we had C++ unit tests! |
Builders don't always specify the block. If it doesn't, this function segfaults.
0411559 to
4a9b49a
Compare
|
Thanks @uenoku ! |
Builders don't always specify the block. If it doesn't, this function segfaults.