[ESI] Fix wrap op canonicalizers #8730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the canonicalizers for wrap operations in the ESI dialect by replacing problematic attribute-based folding with proper operation creation and improving pattern matching logic.
- Updates
WrapValidReadyOpandWrapFIFOOpfold methods to createNullSourceOpoperations instead of using attributes - Improves the
WrapFIFOOpcanonicalize method with better error handling and more robust user checking - Delegates constant materialization to the HW dialect for better consistency
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/Dialect/ESI/canonicalizers.mlir | Adds test cases for dangling FIFO and ValidReady wrap operations |
| lib/Dialect/ESI/ESIFolds.cpp | Updates fold and canonicalize methods to use proper operations and improved logic |
| lib/Dialect/ESI/ESIDialect.cpp | Simplifies constant materialization by delegating to HW dialect |
Comments suppressed due to low confidence (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the canonicalizers for wrap operations in the ESI dialect by replacing problematic attribute-based folding with proper operation creation and improving pattern matching logic.
WrapValidReadyOpandWrapFIFOOpfold methods to createNullSourceOpoperations instead of using attributesWrapFIFOOpcanonicalize method with better error handling and more robust user checking