[HW][AIG] Add InstancePath CAPI and use native structures for AIG longest path analysis #8760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c32352e to
02dac18
Compare
uenoku
commented
Jul 22, 2025
uenoku
commented
Jul 22, 2025
uenoku
commented
Jul 22, 2025
uenoku
commented
Jul 22, 2025
…gest path analysis This commit refactors the AIG longest path analysis C API to use native C structures instead of JSON strings, providing better performance and type safety. The API changes replace aigLongestPathCollectionGetPath() returning JSON with aigLongestPathCollectionGetDataflowPath() returning native objects. New opaque handle types are added including AIGLongestPathObject, AIGLongestPathHistory, and AIGLongestPathDataflowPath. Comprehensive APIs are provided for accessing path data, history, and object properties. InstanceGraph C API support is introduced in circt-c/Support/InstanceGraph.h. The Python binding updates refactor Object, DataflowPath, and LongestPathHistory classes to use the native C API. JSON parsing dependencies and from_json_string() methods are removed. Proper property accessors using the new C API are added while maintaining backward compatibility for existing Python interfaces. Testing updates include comprehensive coverage in the existing C API tests in test/CAPI/aig.c. A new test/CAPI/support.c is added for InstanceGraph API testing. Python integration tests are updated to work with the new API. This change improves performance by eliminating JSON serialization/deserialization overhead and provides a more robust, type-safe interface for accessing longest path analysis results.
02dac18 to
0833aef
Compare
fabianschuiki
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the AIG longest path analysis C API to use native C structures instead of JSON strings, providing better performance and type safety.
The API changes replace
aigLongestPathCollectionGetPathreturning JSON withaigLongestPathCollectionGetDataflowPathreturning native objects. New opaque handle types are added includingAIGLongestPathObject,AIGLongestPathHistory, andAIGLongestPathDataflowPath. Comprehensive APIs are provided for accessing path data, history, and object properties.InstancePath C API support is introduced in
circt-c/Support/InstanceGraph.h. CurrentlyInstancePathCacheitself is not provided, as the use of LongestPathAnalysis is read-only and there is no need to mutate/construct InstancePath. Unfortunately due to that testing of CAPI of InstancePath got a bit tricky. For now AIGLongestPathAnalysis is used to produce InstancePath in CAPI.The Python binding updates refactor Object, DataflowPath, and LongestPathHistory classes to use the native C API. JSON parsing dependencies and from_json_string() methods are removed. Proper property accessors using the new C API are added while maintaining backward compatibility for existing Python interfaces. So the existing integration tests cover most of the APIs.
Testing updates include comprehensive coverage in the existing C API tests in
test/CAPI/aig.c. A newtest/CAPI/support.cis added for InstancePath API testing. Python integration tests are updated to work with the new API.This change improves performance by eliminating JSON serialization/deserialization overhead and provides a more robust, type-safe interface for accessing longest path analysis results.