[ESI][Runtime] Fixing MMIO to account for relative paths #8814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locating client ports was broken in the case of the MMIO service being not at the top level.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with MMIO (Memory-Mapped I/O) service functionality when it's not located at the top level of the hierarchy. The fix ensures that client ports are properly located by accounting for relative paths in nested service scenarios.
- Updates MMIO constructor to accept an
AppIDPathparameter for proper path context - Adds a
parent()method toAppIDPathfor hierarchical path operations - Fixes path resolution by computing absolute paths from relative client paths
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Xrt.cpp | Updates XrtMMIO constructor to pass AppIDPath parameter |
| Trace.cpp | Updates TraceMMIO constructor to pass AppIDPath parameter |
| Cosim.cpp | Updates CosimMMIO constructor to pass AppIDPath parameter |
| Services.cpp | Modifies MMIO constructor to compute absolute paths from relative client paths |
| Services.h | Updates MMIO constructor signature to include AppIDPath parameter |
| Common.h | Adds parent() method declaration and makes operator+ const |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locating client ports was broken in the case of the MMIO service being not at the top level.