[HW] Accept most reductions even if module size increases #8847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maerhart
approved these changes
Aug 13, 2025
87d3359 to
a3a042c
Compare
5ba59c2 to
571fd3b
Compare
|
Yeah good point, the port reduction should always reduce the module size. I marked them here as well since they are always beneficial, so accepting them should not be contingent on module size. |
dtzSiFive
approved these changes
Aug 13, 2025
| struct HWConstantifier : public Reduction { | ||
| void matches(Operation *op, | ||
| llvm::function_ref<void(uint64_t, uint64_t)> addMatch) override { | ||
| if (op->hasTrait<OpTrait::ConstantLike>()) |
There was a problem hiding this comment.
--> don't try to constant-ify something already a constant? ✅
The HW reductions that replace values with constants and remove module ports are beneficial even when they increase the size of the MLIR text. Removing ports and replacing values with zero removes dependencies in the IR, making it easier to apply other reductions. Make these reductions return true from `acceptSizeIncrease` to have the reducer accept the result even if the module size increases.
a3a042c to
259ca33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HW reductions that replace values with constants and remove module ports are beneficial even when they increase the size of the MLIR text. Removing ports and replacing values with zero removes dependencies in the IR, making it easier to apply other reductions.
Make these reductions return true from
acceptSizeIncreaseto have the reducer accept the result even if the module size increases.