[MooreToCore] Add support for $fatal #8936
Conversation
There was a problem hiding this comment.
Great start with first PR - wohoo!
If it's not too much effort would be great to support the different variants of severity warning/error so we don't need to revisit this next time round - but they seem to be able to share similar lowering with minor changes for each/
| ConversionPatternRewriter &rewriter) { | ||
|
|
||
| if (op.getSeverity() == Severity::Fatal) { | ||
| auto prefix = rewriter.create<sim::FormatLitOp>(op.getLoc(), "Error: "); |
There was a problem hiding this comment.
Nit: would make sense to have "Fatal: " as there is an Error level
There was a problem hiding this comment.
Hi Samuel, adapted the prefix to Fatal: for fatal severity.
| rewriter.replaceOpWithNewOp<sim::PrintFormattedProcOp>(op, message); | ||
| return success(); | ||
| } | ||
| return failure(); |
There was a problem hiding this comment.
Would it be possible to add support to handle error and warning in the same way - just with modified prefixes?
There was a problem hiding this comment.
Add a switch-case statement to match for Warning and Error. Extended the test as well.
| // CHECK-LABEL: @SeverityToPrint | ||
| func.func @SeverityToPrint() { | ||
| // CHECK: [[MSG:%.*]] = sim.fmt.lit "Error condition met!\n" | ||
| // CHECK-NEXT: [[PFX:%.*]] = sim.fmt.lit "Error: " |
There was a problem hiding this comment.
Nit: will need to extend tests for other cases if added?
There was a problem hiding this comment.
Test has been extended.
There was a problem hiding this comment.
LGTM - thanks for the corrections - will merge pending any additional comments from @fabianschuiki?
There was a problem hiding this comment.
Very neat! Thanks for implementing this @Scheremo 🥳. Want us to merge this for you?
Yes please! Thanks again for all your help @fabianschuiki @cowardsa, and my pair programming partner @JosseVanDelm |
This PR implements support for
$fatalsystem tasks in system verilog as discussed in issue #8934.Thanks for generous support by @JosseVanDelm @towoe @cowardsa