[MooreToCore] Support slicing of nested arrays #9073
Merged
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
734
to
747
| if (auto resArrTy = dyn_cast<hw::ArrayType>(resultType)) { | ||
| if (auto resArrTy = dyn_cast<hw::ArrayType>(resultType); | ||
| resArrTy && arrayNestingLevel(resArrTy) == arrayNestingLevel(arrTy)) { |
There was a problem hiding this comment.
I remember @jpienaar fixing a similar issue for ExtractRefOp a few weeks ago:
Do you think we could use a similar way of checking for slicing vs. element access, by checking whether the arrType.getElementType() != resultType? That would avoid having to reason about nesting levels of arrays, and would turn this into a quick pointer equality check.
There was a problem hiding this comment.
That seems way better. I updated the code. Initially, I wasn't sure if there may be edge-cases I hadn't thought about. All tests pass though.
9261708 to
a4de7d6
Compare
fabianschuiki
approved these changes
Oct 10, 2025
Added a testcase that is the result of parsing the following sv code: ```sv module bug ( input logic [1:0][1:0][1:0] wr_addr, output logic [1:0] out ); assign out = wr_addr[0][0][1:0]; endmodule ``` The current MooreToCore pass translates the sv ode incorrectly to ``` hw.module @bug(in %wr_addr : !hw.array<2xarray<2xi2>>, out out : i2) { %false = hw.constant false %0 = builtin.unrealized_conversion_cast %wr_addr : !hw.array<2xarray<2xi2>> to !hw.array<2xi2> %1 = hw.array_get %0[%false] : !hw.array<2xi2>, i1 hw.output %1 : i2 } ``` Adding a check if operand and result array have the same level of nesting in the ExtractOpConversion fixes the bug.
a4de7d6 to
c5da9e1
Compare
|
Thanks! I rebased to head to resolve the conflict and pushed my branch again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a testcase that is the result of parsing the following sv code:
The current MooreToCore pass translates the sv ode incorrectly to
Adding a check if operand and result array have the same level of nesting in the ExtractOpConversion fixes the bug.