[ImportVerilog][Moore] Add real-to-int & int-to-real operators #9088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5544dc to
82f0dc5
Compare
1021e73 to
543f25b
Compare
fabianschuiki
approved these changes
Oct 13, 2025
This commit introduces explicit conversion operations between real and integer types in the Moore dialect, following IEEE 1800-2023 §6.24.1 *Cast operator* and §6.12 *Real, shortreal and realtime data types*.
It also extends VerilogImport to recognize and materialize these conversions during AST translation.
- **Dialect (`MooreOps.td`)**
- Added `RealToIntOp` for rounding real/shortreal values to two-valued integers.
- Added `IntToRealOp` for widening integer values to real/shortreal.
- Both ops marked `Pure` with explicit assembly formats.
- **Import logic (`Expressions.cpp`)**
- Added conversion handling in `Context::materializeConversion`:
- `RealType` -> `IntType` -> `RealToIntOp`
- `IntType` -> `RealType` -> `IntToRealOp`
- **Tests**
- **SystemVerilog import**
- Added `basic.sv` tests verifying correct lowering of `real'(expr)` and `int'(expr)` casts for all real/int width combinations (`f32/i32`, `f64/i64`).
- Updated `builtins.sv` to expect `moore.int_to_real` instead of a generic `conversion` op.
- **Dialect MLIR**
- Added `basic.mlir` tests ensuring proper parsing/printing and type mapping for 32- and 64-bit conversions.
543f25b to
c1ae7ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces explicit conversion operations between real and integer types in the Moore dialect, following IEEE 1800-2023 §6.24.1 Cast operator and §6.12 Real, shortreal and realtime data types. It also extends VerilogImport to recognize and materialize these conversions during AST translation.
Dialect (
MooreOps.td)RealToIntOpfor rounding real/shortreal values to two-valued integers.IntToRealOpfor widening integer values to real/shortreal.Purewith explicit assembly formats.Import logic (
Expressions.cpp)Context::materializeConversion:RealType->IntType->RealToIntOpIntType->RealType->IntToRealOpTests
basic.svtests verifying correct lowering ofreal'(expr)andint'(expr)casts for all real/int width combinations (f32/i32,f64/i64).builtins.svto expectmoore.int_to_realinstead of a genericconversionop.basic.mlirtests ensuring proper parsing/printing and type mapping for 32- and 64-bit conversions.