Merged
Conversation
lmittmann
requested changes
Aug 7, 2025
w3vm/vm.go
Outdated
| } | ||
|
|
||
| // Clone creates a new VM with a copy of the current VM's options and a snapshot of its state. | ||
| func (vm *VM) Clone() (*VM, error) { |
Owner
There was a problem hiding this comment.
I would prefer if the signature is simply
func (vm *VM) Clone() *VMand if instead of using options and New just copy the opts and create a VM instance directly. For many attributes like the fetcher a shallow copy is completely fine
Contributor
Author
There was a problem hiding this comment.
done!
also rebased and squashed
62227c1 to
39d8aec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements VM.Clone() with a variety of tests.
closes #267