-
Notifications
You must be signed in to change notification settings - Fork 32
ansititle: add windows support #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
fixed the code formatting |
|
|
Nice PR! What happens if someone is using something other than Windows Terminal on Windows? |
|
it doesn't do anything since most other custom terminals don't work with the windows api, i could probably try to come up with a fix if you want though |
|
If it doesn't crash the host, then that might be good enough in that the unhappy path would be no different from the current code you're improving upon. Do you know if there is a reliable way to check if the term is a Windows Terminal instance? |
|
no i don't know, it doesn't crash the host though that's for sure |
|
Awesome. Great work on this PR! |
# v7.1 This release focuses mainly on bugfixes and quality-of-life with the exception of three **experimental** new major additions: * `foreach` now supports running processes in parallel * `fanout` is a new builtin that allows sending stdout to the stdin of many processes * `md` is a new datatype added. Currently only supports rendering markdown tables but more features will follow in future releases ## Breaking Changes None ## v7.1.xxxx ### Features * `fanout`: new builtin (EXPERIMENTAL) * REPL: default prompt modernized * ANSI titlebar: Windows support added ([PR](#931)) * autocomplete: add support for substring matches ([discussion](#934)) * autocomplete: remove `stat` syscall from recursive directory lookups to improve performance * `foreach`: parallel support added (EXPERIMENTAL) ([discussion](#933)) * macro vars: history support added (history stored in cache.db) * integrations: `basti` autocomplete * integrations: Charm Bracelet's `freeze` * tooling: Makefile added for simplified development on POSIX systems * `runtime --about`: `GOMAXPROCS` field added * xml: improved interop between CSV and XML * core: data types can now register what their layout type is. Allowing for `format` to better deduce how to reformat the data. eg next few refinements below * csv: support for JSON and YAML maps * yaml: convert tables to maps * json: convert tables to maps * `select`: support for maps * `config`: new option: **syntax-completion-enabled** * `config`: new option: **history-write-enabled** * md: new datatype, markdown (EXPERIMENTAL) * murex: new flag added: `-ignore-whatsnew` * core: hint text added for `cd -` ([PR](#951)) * core: errors reformatted to make them slightly easier to read * `test`: default test report now uses the full width of the terminal, plus other minor readability improvements * docgen: new functions added * docgen: support for metadata * Update dependencies ### Bug Fixes * `datetime`: stdout datatype set to `str` * `fid-kill`: autocomplete fix ([issue](#949)) * exec: don't error on wait if PID is already closed ([issue](#946)) * spellcheck: fixed bug causing users to be re-prompted when `aspell` isn't installed * REPL: fixed regression bug causing hint text not to display application hints * `murex-package`: working directory preserved when installing packages * readline: panic fixed in command line preview * cache.db: fixed potential race condition when checking if cache.db is enabled * REPL: fixed potential race condition when instantiating `readline` * tests: `env` test skips on Windows, uses full path on POSIX * tests: skip tilde parser test if username contains non-var chars (eg `@`) * readline: null check when using tab grid * readline: improved SGR detection * readline: fixed wider character rendering bug when using tab grid * readline: fixed potential race condition with read/write access to unicode slices * readline: fixed potential race condition with terminal width caching * readline: fixed potential race condition with asynchronous updates to tab completion * readline: fixed potential race condition with hint text height reporting * readline: fixed potential race condition with tab completion height reporting * readline: fixed potential race condition with previews * readline: fixed potential race condition with hint text cache ## Special Thanks Thank yous for this release goes to [TheBearodactyl](https://github.com/TheBearodactyl), [JeffMelton](https://github.com/JeffMelton), [Th0rgal](https://github.com/Th0rgal), [lokalius](https://github.com/lokalius), [tiymat](https://github.com/tiymat) for your code, testing and feedback. Also thank you to everyone in the [discussions group](https://github.com/lmorg/murex/discussions) and all who raise bug reports. You rock!
setting the titlebar-func in the shell config now works on windows
2025-07-23.20-12-40.mp4