deduplicate tags, remove deprecated tests #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 46c3608 in 47 seconds. Click for details.
- Reviewed
264lines of code in3files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/decorators.ts:82
- Draft comment:
Good use of Array.from(new Set(tags)) to deduplicate tags. This approach is succinct and preserves insertion order. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. src/laminar.ts:407
- Draft comment:
Consistent deduplication logic in setSpanTags improves data hygiene. Consider refactoring if similar code appears elsewhere. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. src/laminar.ts:480
- Draft comment:
Deduplication is now applied to tags in startSpan as well. This ensures consistency, though consider extracting common deduplication logic if repeated in multiple methods. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. test/tracing.test.ts:305
- Draft comment:
New tests verifying duplicate tag removal in both observe and startSpan are comprehensive and validate the deduplication logic. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. test/tracing.test.ts:759
- Draft comment:
Deprecated tests related to labels have been removed, reducing maintenance overhead. Ensure deprecation notices are clear in the documentation. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_xHxhTF2Zg5tsP49d
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed c967646 in 56 seconds. Click for details.
- Reviewed
27lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/laminar.ts:480
- Draft comment:
Reformatted ternary for 'tagProperties' to improve readability. Deduplication via Array.from(new Set(tags)) remains correct. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. test/tracing.test.ts:9
- Draft comment:
Removed deprecated 'withLabels' import to clean up unused code. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_Z0awT8xDcMB9E4lx
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Deduplicate tags in
observeandstartSpanfunctions, and remove deprecated label tests.observefunction indecorators.tsandstartSpanandsetSpanTagsmethods inlaminar.tsusingSet.labelsparameter fromstartSpanmethod inlaminar.ts.tracing.test.tsto verify tag deduplication inobserve,startSpan, andsetSpanTags.withLabelsintracing.test.ts.This description was created by
for c967646. You can customize this summary. It will automatically update as commits are pushed.