-
Notifications
You must be signed in to change notification settings - Fork 167
build(deps): bump react-resizable-panels from 2.1.9 to 4.0.15 in /frontend #1119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
build(deps): bump react-resizable-panels from 2.1.9 to 4.0.15 in /frontend #1119
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! π
Reviewed everything up to 7dd9904 in 1 minute and 27 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
1files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with π or π to teach Ellipsis.
1. frontend/package.json:117
- Draft comment:
Dependency bump from ^2.1.9 to ^4.0.15 is a major update with breaking changes (e.g. renaming of groupId to id in useDefaultLayout and changes in defaultLayout behavior). Please verify that all usages of react-resizable-panels conform to the new API. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% The rules explicitly state "Do NOT comment on dependency changes, library versions that you don't recognize, or anything else related to dependencies." This comment is clearly about a dependency change - it's commenting on a version bump in package.json. Even though the comment provides specific information about breaking changes, it's still fundamentally a comment about a dependency update. The rule is clear and unambiguous: dependency changes should not be commented on. The assumption is that the PR author knows what they're doing when updating dependencies, and any breaking changes would be caught during testing or the build process. Could this be an exception since it's a major version bump with breaking changes that might not be caught by the build? Perhaps the rule about dependencies is meant for minor updates, not major breaking changes that could cause runtime issues. While major version bumps with breaking changes could be more significant, the rule about dependencies doesn't make exceptions for major vs minor updates. It says "Do NOT comment on dependency changes" without qualification. Additionally, the comment asks the author to "verify" usage, which falls under the rule "Do NOT ask the PR author to confirm their intention, to explain, to double-check things, to ensure the behavior is intended" - it's asking them to verify/double-check. This comment should be deleted because it violates the rule against commenting on dependency changes. Additionally, it asks the PR author to "verify" usage, which is explicitly discouraged by the rules.
Workflow ID: wflow_LygmnjLu4ddvTZWw
You can customize by changing your verbosity settings, reacting with π or π, replying to comments, or adding code review rules.
7dd9904 to
3259e8b
Compare
Bumps [react-resizable-panels](https://github.com/bvaughn/react-resizable-panels) from 2.1.9 to 4.0.15. - [Release notes](https://github.com/bvaughn/react-resizable-panels/releases) - [Changelog](https://github.com/bvaughn/react-resizable-panels/blob/main/CHANGELOG.md) - [Commits](bvaughn/react-resizable-panels@2.1.9...4.0.15) --- updated-dependencies: - dependency-name: react-resizable-panels dependency-version: 4.0.15 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
3259e8b to
8f51cc0
Compare
Bumps react-resizable-panels from 2.1.9 to 4.0.15.
Release notes
Sourced from react-resizable-panels's releases.
... (truncated)
Changelog
Sourced from react-resizable-panels's changelog.
... (truncated)
Commits
06e72eb4.0.14 -> 4.0.156db7cc9Ignore defaultLayouts with mismatching Panel ids (#556)281b343Fix Next test appfb153d5Tweaked landing page copyf8bf881Tweaked landing page copy0cbd6a9Update CHANGELOGf96f4cc4.0.13 -> 4.0.14a5691a0Allow resizable panels to be rendered into a different Window (e.g. popup or ...ca9b9b7Improved e2e test harness serialization9711ece4.0.12 -> 4.0.13You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Upgrades the resizable panels library and refreshes transitive dependencies; no application code changes.
react-resizable-panelsinfrontend/package.jsonto^4.4.1pnpm-lock.yamlaccordingly, including newer versions of CodeMirror packages,watchpack,terser, and@types/nodereact-resizable-panelspeer deps now specifyreact/react-dom^18 || ^19Written by Cursor Bugbot for commit 8f51cc0. This will update automatically on new commits. Configure here.
Important
Bump
react-resizable-panelsfrom 2.1.9 to 4.0.15, introducing new features and bug fixes.react-resizable-panelsfrom 2.1.9 to 4.0.15 inpackage.json.defaultLayoutwhen keys don't match Panel ids.element.ownerDocument.defaultView.groupIdparameter inuseDefaultLayoutin favor ofid.storage.setItemcalls by 150ms inuseDefaultLayout.This description was created by
for 7dd9904. You can customize this summary. It will automatically update as commits are pushed.