Hotfix/ack browser events #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 206b69a in 58 seconds. Click for details.
- Reviewed
38lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. app-server/src/browser_events/mod.rs:95
- Draft comment:
Removed duplicate ack call on successful insert. Now the message is acked only once (line 95) before updating stats. Ensure this behavior (ack before stats update) is acceptable and doesn't mask any potential insert issues. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. app-server/src/ch/browser_events.rs:41
- Draft comment:
Removed the 'wait_for_async_insert' option. Verify that not waiting for async insert completion is intentional and acceptable for reliability/performance trade-offs. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to verify their intention regarding the removal of an option. This falls under the rule of not asking the author to confirm their intention or ensure behavior is intended. Therefore, this comment should be removed.
Workflow ID: wflow_N7MsFNGAYaq2K8ub
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
olzhik11
added a commit
that referenced
this pull request
Jun 26, 2025
* estimate span size before any processing (#654) * Feat/lam 682 (#655) * feat: update delete project, fix spans filters * fix: rendering, model fallback * feat: move delete endpoint to next * feat: fix margins * feat: update delete project data in ch, fix comments * fix: command * feat: add debug console * feat: move helper function * allow CTES in SQL editor (#653) * allow CTES in SQL editor * remove debug console.log * fix reset usage when upgrading (#657) * Hotfix/ack browser events (#660) * first ack browser events, then increment usage * don't wait for async insert on browser events * feat: fix decode key by passing in docker file (#661) * feat: fix decode key by passing in docker file * feat: add key to full build --------- Co-authored-by: Dinmukhamed Mailibay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Reorder message acknowledgment in
inner_process_browser_events()and removewait_for_async_insertoption ininsert_browser_events()for improved processing.acker.ack()call beforeincrement_project_browser_events_bytes_ingested()ininner_process_browser_events()inmod.rsto ensure message acknowledgment occurs earlier.wait_for_async_insertoption ininsert_browser_events()inbrowser_events.rsto modify ClickHouse insert behavior.inner_process_browser_events()inmod.rs.This description was created by
for 206b69a. You can customize this summary. It will automatically update as commits are pushed.