feat: add telemetry #686
Merged
feat: add telemetry #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Contributor
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 7a08fe9 in 1 minute and 25 seconds. Click for details.
- Reviewed
86lines of code in2files - Skipped
1files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. frontend/instrumentation.ts:1
- Draft comment:
The top comment indicates the file isn’t used for instrumentation. Update it if telemetry is now active to avoid confusion. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. frontend/instrumentation.ts:44
- Draft comment:
Reference to entry.data[0] assumes non-empty data. Consider adding a guard to prevent runtime errors if entry.data is empty. - Reason this comment was not posted:
Comment was on unchanged code.
3. frontend/package.json:73
- Draft comment:
New dependency '@vercel/otel' is added. Confirm that version ^1.13.0 is compatible with your telemetry requirements. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_bg0m15iF80JdkXh6
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 8129731 in 33 seconds. Click for details.
- Reviewed
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. frontend/instrumentation.ts:10
- Draft comment:
Telemetry registration is now wrapped in a production-only check. Ensure that disabling telemetry in non-production environments (e.g., staging) is intended. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_eIkZooYI4H3yq1c9
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
dinmukhamedm
added a commit
that referenced
this pull request
Jul 8, 2025
…script (#690) * feat: pass speed options (#682) * remove cloning attributes as much as possible (#681) * wip: remove cloning attributes as much as possible * small refactor for testability + clone after filter * tiny change, remove unnecessary ref * add unit testing * feat: enhance traces/shared traces (#683) * feat: enhance traces WIP * feat: update shared trace * feat: refactor styles, add space listener, fix hydration error * feat: trace id fix, default props to store, refactor store * feat: add spanId as prop, fix navigation config * feat: remove logs, add orderby to spans search * feat: fix comments * feat: update table columns * feat: fix default width on client side * feat: update evaluation trace view * remove clones, slight refactor, .remove from hashmap where possible (#684) * remove clones, slight refactor, .remove from hashmap where possible * replace ai.prompt.tools in place per ellipsis * Feat/custom renderer (#676) * feat: custom renderer wip * feat: custom renderer * feat: update to jsx renderer * fix * feat: small fixes * remove hover * feat: refactor * feat: fix update of custom renderer * feat: update custom renderer * fixes --------- Co-authored-by: Robert Kim <[email protected]> * feat: add telemetry (#686) * feat: add telemetry * feat: run otel only in prod * allocator (#687) * cleanup unused DB schema and code (#685) * cleanup unused DB schema and code * fix build * return newly created tag class * address ellipsis * feat: fix css in rrweb events (#688) * Feat/lam 653 (#678) * feat: add domain check logic * feat: remove agent chat feature * feat: remove idnex from landing, .env * feat: remove hardcoded value * fix: link * feat: revert * update @codemirror/language (#691) * fix: update cache update query to new pricing mode (#689) * force update lockfile --------- Co-authored-by: Olzhas Nurpeisov <[email protected]> Co-authored-by: Robert Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add OpenTelemetry integration for production environments using
@vercel/otel.registerOTelfrom@vercel/otelininstrumentation.tsto enable telemetry in production environments.process.env.ENVIRONMENT === "PRODUCTION"to ensure telemetry only runs in production.@vercel/oteltodependenciesinpackage.json.This description was created by
for 8129731. You can customize this summary. It will automatically update as commits are pushed.