feat: add export to labeling queue from sql editor#800
Open
Conversation
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to e6b0c5c in 1 minute and 19 seconds. Click for details.
- Reviewed
388lines of code in5files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. frontend/app/api/projects/[projectId]/queues/[queueId]/push/route.ts:9
- Draft comment:
Removed upfront schema validation (safeParse) from the request body. Confirm that pushQueueItems now handles validation appropriately. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. frontend/app/invitations/page.tsx:10
- Draft comment:
Removed debug console.log statements. Ensure this cleanup is intentional for production. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. frontend/components/queue/queue.tsx:80
- Draft comment:
Added new routing for items with source 'sql' to navigate to /project/{projectId}/sql/{id}. This change appears correct. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, stating that the change appears correct. It doesn't provide any actionable feedback or suggestions for improvement.
4. frontend/components/sql/export-sql-dialog.tsx:262
- Draft comment:
In ExportLabelingQueueDialog, ensure that 'id' from useParams is the intended identifier for the SQL export. Also, consider refactoring common drag‐and‐drop and column mapping logic shared with ExportDatasetDialog to reduce duplication. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% The first part about 'id' is asking for confirmation/verification, which violates our rules about not asking authors to verify things. The second part about refactoring is a valid code quality suggestion that points out clear duplication. However, since this is a new feature being added, suggesting refactoring of the implementation details feels premature - let's get the feature working first. I might be too quick to dismiss the refactoring suggestion - duplicated code can lead to maintenance issues and bugs. Also, the 'id' parameter usage could be a real bug if it's the wrong ID. While these concerns are valid, the comment violates our rules: it asks for verification and makes a premature optimization suggestion. If there was a clear bug with the ID usage, that would be different, but the comment just asks to verify it. Delete the comment. It primarily asks for verification and makes a premature optimization suggestion, both of which violate our review guidelines.
5. frontend/lib/actions/queue/index.ts:27
- Draft comment:
Added 'sql' as an allowed source in the PushQueueItemSchema. Verify that this change aligns with front-end usage and overall queue processing. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to verify alignment with front-end usage and overall queue processing, which falls under asking the author to confirm their intention or ensure behavior is intended. This violates the rules.
Workflow ID: wflow_UCPDZtKKtyyNe2xQ
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
skull8888888
requested changes
Aug 16, 2025
| ); | ||
| } | ||
|
|
||
| function ExportLabelingQueueDialog({ |
Member
There was a problem hiding this comment.
why do we need separate component to export to labeling queue which exactly mimics the export to dataset dialog? We just need to modify export code of original export dialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Adds feature to export SQL results to labeling queue with updated queue handling and error management.
ExportLabelingQueueDialoginexport-sql-dialog.tsxto export SQL results to a labeling queue.ExportSqlDialogto include an option for exporting to a labeling queue.pushQueueItemsinroute.tsto handle SQL source metadata.PushQueueItemSchemainqueue/index.tsto includesqlas a source.QueueInnerinqueue.tsx.ZodErrorhandling inroute.ts.page.tsx.This description was created by
for e6b0c5c. You can customize this summary. It will automatically update as commits are pushed.