Improved env layout #2226
Improved env layout #2226
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2226 +/- ##
==========================================
+ Coverage 59.24% 59.26% +0.02%
==========================================
Files 60 60
Lines 8992 8992
==========================================
+ Hits 5327 5329 +2
+ Misses 3665 3663 -2 ☔ View full report in Codecov by Sentry. |
|
once again i use this opportunity to questions if admin_ui should be enabled by default, because i think it should be. |
Its easy enough to enable on first launch with I also feel we willl end up defaulting, but it should be a slow move, to encourage users to use. |
| # Enable Admin GUI, available for the first user in LNBITS_ADMIN_USERS if available | ||
| # Warning: Enabling this will make LNbits ignore this configuration file. Your settings will | ||
| # be stored in your database and you will be able to change them only through the Admin UI. | ||
| # Disable this to make LNbits use this config file again. |
There was a problem hiding this comment.
Some settings like DB connection, LNBITS_ADMIN_UI itself (and others) are always read from the environment variables (.env file or actual env vars).
These settings are grouped under the ReadOnlySettings class. Suggested change below.
LNBITS_ADMIN_UI has become the most important variable, so should be at the top of the file