Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

Comparison is base (54c6faa) 59.17% compared to head (18869b8) 58.81%.

@@            Coverage Diff             @@
##              dev    #2229      +/-   ##
==========================================
- Coverage   59.17%   58.81%   -0.36%     
==========================================
  Files          60       60              
  Lines        9036     9133      +97     
==========================================
+ Hits         5347     5372      +25     
- Misses       3689     3761      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Great idea ! If the payment is dependant on the version as in the video that means that hotfixes for it are also behind a paywall ?

interesting issue. I think its possible that once paid, you get access to all future updates.

If the extension does not contain pay_link and the user has already paid for the previous version then this update is for free.

So let's say extension 1.0 and extension 2.0 have pay_links and versions 1.1, 1.2, 2.1 and 2.2 don't. In that case you need to pay only for the major version update, but not for minor version updates.

At least that is how I understand this feature is implemented.

@arbadacarbaYK @prusnak regarding the pay_link:

• paid releases are required to have a pay_link field, see description here.

  • multiple releases can have the same pay_link (no need to pay again for a new release install)
  • but it is possible that some releases (eg. major upgrade) have their own pay_link, thus requiring a new payment to install them

• if an extension is un-installed then the payment history is lost

• if no pay_link field, then it is free to install

Those this ☝️ answer your concerns?

If the extension does not contain pay_link and the user has already paid for the previous version then this update is for free.

• no pay_link means it is free
• multiple releases can have the same pay_link, a diferent zip file is downloaded based on the version value (see paywall ext readme also)
• the user pays only once for a pay_link

So let's say extension 1.0 and extension 2.0 have pay_links and versions 1.1, 1.2, 2.1 and 2.2 don't. In that case you need to pay only for the major version update, but not for minor version updates.

At least that is how I understand this feature is implemented.

• the releases 1.1, 1.2 must have the same pay_link as 1.0, user only pays once and can install any of the 3 version
• the releases 2.1, 2.2 must have the same pay_link as 2.0

@motorina0 ah yes. That is even better. Love this!