Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: cannot change user password #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix: cannot change user password #2239

merged 1 commit into from
Feb 6, 2024

Conversation

@motorina0
Copy link
Collaborator

@motorina0 motorina0 commented Feb 6, 2024 •
edited
Loading

Summary

Check for username before allowing password change

Steps:

  • create a new account
  • go to Account page an try to change the password

Actual Result:

  • an error message is displayed: [{'loc': ('body', 'username'), 'msg': 'field required', 'type': 'value_error.missing'}]

Expected Result:

  • a nice message is displayed asking the user to set an username first
  • username/password login is not possible without a username

image

Workaround:

  • set a username before changing the password

Cause:

  • regression bug from "Install wizard on first launch" feature

@codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22ea83e) 51.89% compared to head (d0c837e) 59.22%.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2239      +/-   ##
==========================================
+ Coverage   51.89%   59.22%   +7.32%     
==========================================
  Files          60       60              
  Lines        9018     9018              
==========================================
+ Hits         4680     5341     +661     
+ Misses       4338     3677     -661

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@motorina0 motorina0 changed the title fix: check for username before allowing password change fix: cannot change user password Feb 6, 2024
@motorina0 motorina0 added this to the 0.12.0 milestone Feb 6, 2024
@motorina0 motorina0 merged commit 59968e3 into dev Feb 6, 2024
@motorina0 motorina0 deleted the fix_password_update branch February 6, 2024 09:48
@motorina0 motorina0 mentioned this pull request Feb 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dni dni dni approved these changes

@talvasconcelos talvasconcelos talvasconcelos approved these changes

@arcbtc arcbtc Awaiting requested review from arcbtc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@motorina0 @dni @talvasconcelos